MetaBufferEstimator Patch for GEOT-4238 #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

fgdrf commented Aug 21, 2012

see Description at http://jira.codehaus.org/browse/GEOT-4238

The Problem : the MetaBufferEstimator have't handled the image size of ExternalGraphics correctly. If the size of the Graphic has been set, the width and height of the image were ignored.

Cheers,
Frank

Owner

aaime commented Sep 15, 2012

Hey, sorry for taking so long at looking to this one.
Generally speaking it seems good, but I don't believe it will work if the size is not a literal, but a feature attribute dependent expression. It seems the code only cares for the case of no declared size and literal size?

Contributor

fgdrf commented Sep 15, 2012

No problem at all! And your are right.

The idea was to respect the image size if the picture has a shape of a rectangle. In this case the image will be resized to the height of the given size parameter. If the width of the image is larger then the width it will take the size of the width instead of the height.
I only happens if the image and the size are literals.

Owner

aaime commented Dec 2, 2012

Patch manually merged on trunk, amending the issue with dynamic sizes and merging it with the work Sebastian Graca made on SE 1.1 inline content for external graphic.

@aaime aaime closed this Dec 2, 2012

simboss added a commit to ccancellieri/geotools that referenced this pull request Nov 20, 2013

simboss added a commit to ccancellieri/geotools that referenced this pull request Nov 20, 2013

tkunicki added a commit to tkunicki/geotools that referenced this pull request Feb 13, 2014

tkunicki added a commit to tkunicki/geotools that referenced this pull request Feb 15, 2014

tkunicki added a commit to tkunicki/geotools that referenced this pull request Feb 19, 2014

tkunicki added a commit to tkunicki/geotools that referenced this pull request Feb 28, 2014

tkunicki added a commit to tkunicki/geotools that referenced this pull request Feb 28, 2014

tkunicki added a commit to tkunicki/geotools that referenced this pull request Mar 6, 2014

@fgdrf fgdrf deleted the fgdrf:fgdrf_mbe branch Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment