Implementation for SE-1.1 InlineContent in ExternalGraphic #30

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

sgraca commented Sep 22, 2012

It supports any base64 encoded image handled by ImageIO.
A new method had to be added to interface org.geotools.styling.StyleFactory to implement this functionality.

Sebastian Graca Added support for <InlineContent> child of <ExternalGraphic> SLD elem…
…ent.

Only base64-encoded image data is supported.
e0f2458
Owner

aaime commented Sep 22, 2012

I could not try building this patch, but overall it looks fine. Have you tried a full build?
One important thing to mention here, the SLDParse is the SLD 1.0 parser, with extensions, the SLD 1.1 parser is in xsd-sld instead. In other words, if someone tries to submit a SLD 1.1 document to the real SDL 1.1 parser, the parse will keep on failing like before.

sgraca commented Sep 23, 2012

I implemented support for base64-encoded InlineContent in SLD 1.1 parser. Should I revert changes in org.geotools.styling.SLDParser then?
I did a full build and it passed without errors.

Owner

jodygarnett commented Nov 10, 2012

I think it will be fine the SLDParser is a beast that tries to read everything, and already contains vendor extensions and support for a few SLD 1.1 things.

The SLD 1.1 parser is the good long term bet.

Owner

aaime commented Nov 10, 2012

Veeery long term. We have had for ages and it cannot parse all our vendor extensions, nor we fully support SLD 1.1. It seems there is just no interest among the people that can fund core development.

Owner

aaime commented Nov 25, 2012

Looked at the patch, looks good to me, just sharing it with the community on gt-devel since it adds a new public method to a public interface, thus breaking its API (I think it's fine, but don't want to just go and perform an API change based on my gut).

aaime closed this Dec 2, 2012

Owner

aaime commented Dec 2, 2012

Closed the pull request as I'm applying it with a small modification, the pull request got outdated enough that it was not possible to apply it directly anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment