Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureCollection cleanup (GEOT-4181) #44

wants to merge 54 commits into from


None yet
1 participant
Copy link

commented Oct 31, 2012

This pull request is taken from the following change proposal:

This is an API change for FeatureCollection:

  • Remove CollectionListener methods (addListener, removeListener)
  • Remove Iterator Methods (iterator, close, purge)
  • Remove Collection Methods (add,adAll,clear,remove,removeAll,retainAll)

This has the consequence of hitting most of our FeatureCollectionImplementations.

This pull request should not be accepted until:

  • pull request for GeoServer is in place (done)
  • pull request for uDig is in place (done)

Warning: I could not cleanly fix PropertyValueCollection as implemented, as such ValueCollectionTypeBindingTest has an eXcluded test (Update: Justin fixed - thanks Justin)

Upgrade instructions are provided in the pull request (as part of update.rst) and the code examples reproduced on the wiki page for handy cut and paste reference when fixing GeoServer and uDig.

jodygarnett added some commits Sep 17, 2012

sort out jdbc module, mostly use of FeatureIterator with a few cases …
…of needing to use FeatureStore to add to a collection
Fix up validation module. A few cases uses SimpleFeatureCollection as…
… a working set, removing content that hand been handled. Used ListFeatureCollection as the replacement.

jodygarnett added some commits Oct 30, 2012

An interesting fix for Encoder that uses Iterator internally. Made a …
…BridgeIterator for FeatureCollection, and made sure to make it closeable so the result can be cleaned up.
Not a very safe fix, depends on DefaultFeatureCollection being suppli…
…ed by GMLAbstractFeatureCollectionBaseTypeBinding
Fix up KML using BridgeIterator for DocumentTypeBinding, unable to lo…
…cate the place to check for closable so the warning about the iterator not being closed still stands
A few leaps of faith checking for instance of Collection in order to …
…add content. CompositeFeatureCollection was adapted to use FeatureIterator
Careful adjustment of StreamingRenderer, basically duplicate the loop…
…s once for collection/iterator and once for featureCollection/FeatureIterator
First round of bug fixes including addition of BaseFeatureCollection …
…as a replacement for AbstractFeatureCollection that just needs features() method
Using Id filter directly was confused versioned postgis testing. Chan…
…ged it back and introduced an expected(Filter) method to quickly count FeatureIds protected by an instance of check
WARNING unsuccessful fix to PropertyValueCollection (it was not a Fea…

The encoding test in ValueCollectionTypeBindingTest has been eXed out until I can get a code review from Justin.

jodygarnett and others added some commits Nov 3, 2012

Fixing FilterFeatureCollection.
Added FilteringSimpleFeatureCollection for simple feature narrowing, and ensuring #features() method overriden to create filtering feature iterator.
Merge pull request #46 from jdeolive/featurecollection_cleanup_origional
Additional changes to feature collection cleanup branch.
Update BaseFeatureCollection / BaseSimpleFeatureCollection based on P…
…rocessorCollection methods for subCollection and sort
Additional helper methods for DataUtilities taken from ProcessingColl…
…ection class. ProcessingCollection now extends BaseFeatureCollection to avoid code duplication.
QA check on FeatureCollection.accepts combined with utility method Da…
…taUtilities.visit( collection, visitor, progress )

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2012

Discussion is complete on the mailing list, thanks for review Andrea, and testing Justin.


This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2012

Pull request content was rebased and applied to master to work around conflict with StreamingRender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.