GEOT-4301: A fix for the missing CRS info on the parsed GML2 document #45

Merged
merged 3 commits into from Nov 15, 2012

Projects

None yet

3 participants

@gerson721

No description provided.

@jdeolive
Collaborator
jdeolive commented Nov 1, 2012

Thanks Gerson. This looks good. Any chance you might be able to throw together a quick test case? Or add a test case to one of the existing tests? Thanks!

@gerson721

No worries Justin. I actually thought of editing GML2ParsingUtilsTest and adding an extra assertion to test for the existence of CRS in the output FeatureCollection but found that there's no test for me to modify. :-) No probs, I'll write a test case for this one which we can also enrich later on. Cheers!

@jodygarnett
Member

Can we hold off until the feature collection clean up is merged.
I really don't want to deal with merge conflicts now that everything building all the way through.

Jody Garnett

On Friday, 2 November 2012 at 8:42 AM, Justin Deoliveira wrote:

Thanks Gerson. This looks good. Any chance you might be able to throw together a quick test case? Or add a test case to one of the existing tests? Thanks!


Reply to this email directly or view it on GitHub (#45 (comment)).

@jdeolive
Collaborator
jdeolive commented Nov 2, 2012

@jive: i don't think it is appropriate to ask people to wait on the fc cleanup, especially since its not eactly right around the corner. The magic of git allows us to merge/rebase work on branches. If you are having issues doing that i suggest we sort them out.

@jodygarnett
Member

I do think it is appropriate given that the GML parsing was the hardest
part of the cleanup - or I would not of asked.

And as per our meeting the cleanup is right around the corner (or I would
not of mentioned it as a thing to schedule around this week).

Seriously if it was any thing other than GML I would not be fussed.

Jody Garnett

On 02/11/2012, at 6:47 PM, Justin Deoliveira notifications@github.com
wrote:

@jive https://github.com/jive: i don't think it is appropriate to ask
people to wait on the fc cleanup, especially since its not eactly right
around the corner. The magic of git allows us to merge/rebase work on
branches. If you are having issues doing that i suggest we sort them out.


Reply to this email directly or view it on
GitHubhttps://github.com/geotools/geotools/pull/45#issuecomment-10029748.

@jdeolive
Collaborator
jdeolive commented Nov 3, 2012

I disagree. If you want a code freeze please ask for one on the developer list.

@jodygarnett
Member

Will do.

Jody Garnett

On 02/11/2012, at 10:01 PM, Justin Deoliveira notifications@github.com
wrote:

I disagree. If you want a code freeze please ask for one on the developer
list.


Reply to this email directly or view it on
GitHubhttps://github.com/geotools/geotools/pull/45#issuecomment-10033984.

@gerson721

Hi guys,

I've just merged all the changes that's been introduced on upstream/8.x into my 8.x and added my test on top of that. While adding the test, I found that the condition I added to handle the CRS of the GML document doesn't handle the Envelope element, so I've added that as well. Feel free to add my fix when you're done with the code cleanup.

Cheers.

@jdeolive jdeolive merged commit b66372f into geotools:8.x Nov 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment