Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

GEOT-4221 add quotation marks around the "${java.library.path}" #7

Merged
merged 1 commit into from Aug 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

mprins commented Aug 7, 2012

  • GEOT-4221: add quotation marks around the "${java.library.path}" in the top level pom, as described in https://jira.codehaus.org/browse/GEOT-4221 . I'm not sure how this works out on other OS than Windows, so you will need to check this.
  • clean up the Geometries module pom: it overrides the toplevel surefire version (which is a bad idea) and has two surefire elements in the build section (which is strange), it also overrides the top level compiler.
Contributor

jdeolive commented Aug 7, 2012

We try to avoid lumping together unrelated changes into a single commit. Can you break these out as separate commits?

Also, it might make sense for us to quote the java.io.tmpdir as well.

@mprins mprins GEOT-4221: add quotation marks around the "${java.library.path}" in t…
…he top level pom, as described in https://jira.codehaus.org/browse/GEOT-4221 and around the temp dir as well as suggested by @jdeolive
dbaf9d7
Contributor

mprins commented Aug 7, 2012

I'll make a new pull for the Geometries pom cleanup

@jdeolive jdeolive pushed a commit that referenced this pull request Aug 8, 2012

Justin Deoliveira Merge pull request #7 from mprins/GEOT-4221
GEOT-4221 add quotation marks around the "${java.library.path}"
e4e5c31

@jdeolive jdeolive merged commit e4e5c31 into geotools:master Aug 8, 2012

@jdeolive jdeolive pushed a commit that referenced this pull request Aug 8, 2012

@mprins mprins + jdeolive GEOT-4221: add quotation marks around the "${java.library.path}" in t…
…he top level pom.

As described in https://jira.codehaus.org/browse/GEOT-4221 and around the temp dir as well as suggested by @jdeolive. #7
bf56cc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment