Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency converter in popup #38

Closed
gergelyszabo94 opened this issue May 8, 2019 · 4 comments
Closed

Currency converter in popup #38

gergelyszabo94 opened this issue May 8, 2019 · 4 comments
Assignees

Comments

@gergelyszabo94
Copy link
Owner

@gergelyszabo94 gergelyszabo94 commented May 8, 2019

Add a simple currency converter to the extension popup. The hard part about this is finding a free API. If there is no free one that is good consider implementing a serverless service that basically acts as a caching mechanism by requesting an API periodically and storing the result and only returns these stored results when requested from users.

@gergelyszabo94 gergelyszabo94 self-assigned this May 8, 2019
@gergelyszabo94

This comment has been minimized.

Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 9, 2019

Turns out there is an Steam API endpoint that could solve this problem, providing interest rates: https://api.steampowered.com/IInventoryService/GetPriceSheet/v1

@gergelyszabo94

This comment has been minimized.

Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 9, 2019

Could also be useful, looks abandoned though:
http://steam.steamlytics.xyz/api

@gergelyszabo94

This comment has been minimized.

Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 9, 2019

Another one: BrakeValve/dataflow#5

@gergelyszabo94

This comment has been minimized.

Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Oct 29, 2019

So the extension already knows the exchange rates since item pricing was implemented. Adding this is not very hard anymore. Its appearance should be optional, also default values should be settable in options. Add a simple percentage calculator as well.

gergelyszabo94 added a commit that referenced this issue Nov 9, 2019
gergelyszabo94 added a commit that referenced this issue Nov 9, 2019
@gergelyszabo94 gergelyszabo94 moved this from In progress to Done in Kanban Board Nov 10, 2019
@gergelyszabo94 gergelyszabo94 moved this from Done to Released in Kanban Board Nov 10, 2019
@gergelyszabo94 gergelyszabo94 removed this from Released in Kanban Board Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.