Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item names always appearing in English #5

Closed
gergelyszabo94 opened this issue May 7, 2019 · 0 comments
Closed

Item names always appearing in English #5

gergelyszabo94 opened this issue May 7, 2019 · 0 comments
Assignees
Labels
bug

Comments

@gergelyszabo94
Copy link
Owner

@gergelyszabo94 gergelyszabo94 commented May 7, 2019

Reported by https://steamcommunity.com/profiles/76561198291133191/
Even if your browser/steam language is set to something other than English the item that is in focus in the inventory has an English name.
This bug was introduced when I changed the API request to English as some functionality was broken otherwise. For item quality can't be reliably determined when there are so many languages.
The fix should involve getting the name from the page. I have tried getting it from the elements, but it's unreliable. I am working on getting it from the page-context functions but hit some roadblocks.

@gergelyszabo94 gergelyszabo94 self-assigned this May 7, 2019
@gergelyszabo94 gergelyszabo94 added the bug label May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.