Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item pricing #8

Closed
gergelyszabo94 opened this issue May 7, 2019 · 32 comments
Closed

Item pricing #8

gergelyszabo94 opened this issue May 7, 2019 · 32 comments
Assignees
@gergelyszabo94
Labels
enhancement New feature or request

Comments

@gergelyszabo94
Copy link
Owner

@gergelyszabo94 gergelyszabo94 commented May 7, 2019 •
edited

Prices on items in inventories and trade offers.
Ideas:

  • Currency picking, keys as currency
  • Pick from price providers, csgobackpack, cs.money, loot.farm, etc.
  • Option to set your own prices.
  • Option to count sticker value - set a % that the sticker's price should be added.
  • Total inventory value
  • Total value of selected items
@gergelyszabo94 gergelyszabo94 added the enhancement New feature or request label May 7, 2019
@gergelyszabo94 gergelyszabo94 self-assigned this May 7, 2019
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 9, 2019

To get basic market pricing data:
https://steamcommunity.com/market/priceoverview/?country=US&currency=3&appid=730&market_hash_name=AWP%20|%20Electric%20Hive%20(Factory%20New)

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 9, 2019

More info on this:
https://stackoverflow.com/questions/22616644/steam-market-currency-and-xml-format

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 13, 2019

Complete python guide for market scrapping:
https://www.blakeporterneuro.com/learning-python-project-3-scrapping-data-from-steams-community-market/

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 25, 2019

Might be needed to store the prices localy in a "proper" database instead of simply in chrome.storage.local https://developers.google.com/web/ilt/pwa/working-with-indexeddb

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented May 25, 2019

Might also be useful:
https://stackoverflow.com/questions/11030837/chrome-extension-websql-need-background-content-pages-to-access-same-databas

@gergelyszabo94 gergelyszabo94 added this to In progress in Kanban Board Jun 30, 2019
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jun 30, 2019

04e1202

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jun 30, 2019

41f6b87

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jun 30, 2019

5b6ac2d

gergelyszabo94 added a commit that referenced this issue Jul 2, 2019
@gergelyszabo94
bitskins pricing info #8
e169635
gergelyszabo94 added a commit that referenced this issue Jul 4, 2019
@gergelyszabo94
added loot.farm pricing #8
e76e249
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 6, 2019

267fd1e

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 7, 2019

efb0358

gergelyszabo94 added a commit that referenced this issue Jul 7, 2019
@gergelyszabo94
added csgo.tm pricing info #8
c3ed8f7
gergelyszabo94 added a commit that referenced this issue Jul 7, 2019
@gergelyszabo94
using ' instead of &#39 in the master list #8
7a87a86
gergelyszabo94 added a commit that referenced this issue Jul 7, 2019
@gergelyszabo94
added cs.money pricing info #8
3f4930a
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 7, 2019

The price scraping script is about finished in terms of functionality.
I will probably change it up a bit later, but the functionality won't change much.

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 8, 2019

The Lambda function is set to run every night and update:
https://prices.csgotrader.app/latest.json
And archive that day's data in this path:
https://prices.csgotrader.app/YYYY/MM/DD/prices.json

gergelyszabo94 added a commit that referenced this issue Jul 8, 2019
@gergelyszabo94
added new *.csgotrader.app endpoints #8
ca14a64
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 10, 2019

Added pricing provider info as enums - these will be used in the options menu.
fe12f37

gergelyszabo94 added a commit that referenced this issue Jul 11, 2019
@gergelyszabo94
only update latest if received prices from all providers #8
e5c1999
gergelyszabo94 added a commit that referenced this issue Jul 11, 2019
@gergelyszabo94
added exchange rates scraping #8
63d3ada
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 11, 2019

The latest exchange rates the extension will use are available at:
https://prices.csgotrader.app/exchange_rates.json
It auto-updates every 3 hours and also archives in this path format:
https://prices.csgotrader.app/YYYY/MM/DD/exchange_rates.json

gergelyszabo94 added a commit that referenced this issue Jul 13, 2019
@gergelyszabo94
added new keys to local storage for pricing #8
212e253
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 13, 2019

6a2067a

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Jul 13, 2019

4706bcd
The latest price and exchange rate path was modified to:
https://prices.csgotrader.app/latest/prices.json
https://prices.csgotrader.app/latest/exchange_rates.json

gergelyszabo94 added a commit that referenced this issue Jul 13, 2019
@gergelyszabo94
added updatePrice function that stores pricing info in storage.local #8
fde3b49
gergelyszabo94 added a commit that referenced this issue Jul 13, 2019
@gergelyszabo94
added basic pricing info to inventories #8
e81d0be
gergelyszabo94 added a commit that referenced this issue Aug 9, 2019
@gergelyszabo94
added case keys as currency #8
78177f0
gergelyszabo94 added a commit that referenced this issue Aug 9, 2019
@gergelyszabo94
adds BTC, ETH and their denominations as supported currencies #8
f08f5e4
gergelyszabo94 added a commit that referenced this issue Aug 9, 2019
@gergelyszabo94
manipulation and outlier handling #8
087d04d
gergelyszabo94 added a commit that referenced this issue Aug 11, 2019
@gergelyszabo94
added page the explains pricing #8
fe7a452
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Aug 11, 2019

I added a prices page here: https://csgotrader.app/prices
It explains how the prices are calculated and served.

gergelyszabo94 added a commit that referenced this issue Aug 12, 2019
@gergelyszabo94
selected items value feature #8
9a3d1dd
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Aug 12, 2019

image

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Aug 13, 2019

The average market prices from csgobackpack are not always reliable.
I might implement my own market price scrapping.
The architecture would look something like:

  1. A master list of all marketable CS:GO items in S3 or DynamoDB. It can be easily extracted from the existing pricing info.
  2. A lambda function that puts all the items in an SQS queue. Each item is it's own message.
  3. A lambda function that is subscribed to the queue, makes the API call towards Steam to get the market info then stores the result in DynamoDB or S3.
  4. The price scraper script modified to use this pricing data instead or in addition to current sources.

As usual, if there are throttling issues from Steam's side it could get much more complicated...

gergelyszabo94 added a commit that referenced this issue Aug 13, 2019
@gergelyszabo94
alphabetical and price based sorting #8
9a86a61
gergelyszabo94 added a commit that referenced this issue Aug 13, 2019
@gergelyszabo94
sorting based on tradability #8
eddeef0
gergelyszabo94 added a commit that referenced this issue Aug 14, 2019
@gergelyszabo94
sorting as dropdown, sort by position #8
d648ad3
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Aug 14, 2019

image

@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Aug 14, 2019

It needs SIH or navigating to at least to the 4th page to trigger the full inventory's loading.
I will work on #47 tonight to eliminate the need for SIH in inventories. (except the occasional mass listing which is still not planned to be implemented in the near future.

gergelyszabo94 added a commit that referenced this issue Aug 14, 2019
@gergelyszabo94
pricing algorithm update #8
aa9da05
gergelyszabo94 added a commit that referenced this issue Aug 15, 2019
@gergelyszabo94
fixes function bar sometimes getting added twice #8
e5ecaf6
gergelyszabo94 added a commit that referenced this issue Aug 15, 2019
@gergelyszabo94
moved sorting modes to enums #8
0e2c970
gergelyszabo94 added a commit that referenced this issue Aug 15, 2019
@gergelyszabo94
option to set default inventory sorting method #8
bb5cb0b
@gergelyszabo94
Copy link
Owner Author

@gergelyszabo94 gergelyszabo94 commented Aug 17, 2019

Comment to possible own market prices scraping implementation:
https://steamcommunity.com/market/pricehistory/?appid=730&market_hash_name=P250%20%7C%20Asiimov%20(Field-Tested)
With calls like this it's possible to extract more detailed information.

gergelyszabo94 added a commit that referenced this issue Aug 18, 2019
@gergelyszabo94
waits for full inventory load before initial sorting #8
d655218
gergelyszabo94 added a commit that referenced this issue Aug 18, 2019
@gergelyszabo94
item sorting in trade offers, sorting generaliztion #8
13d62bd
gergelyszabo94 added a commit that referenced this issue Aug 18, 2019
@gergelyszabo94
option to set default sorting mode for trade offers #8
3369f72
gergelyszabo94 added a commit that referenced this issue Aug 18, 2019
@gergelyszabo94
fixes items in offer not being movable after sorting, more robust and…
aaac742 
… general sorting #8
gergelyszabo94 added a commit that referenced this issue Aug 19, 2019
@gergelyszabo94
offer sorting applies to the other party's inventory as well #8
f282c72
gergelyszabo94 added a commit that referenced this issue Aug 19, 2019
@gergelyszabo94
doppler prices based on phases for csgotrader and csmoney providers #8
86cdbfa
@gergelyszabo94 gergelyszabo94 moved this from In progress to Done in Kanban Board Aug 19, 2019
@gergelyszabo94 gergelyszabo94 moved this from Done to Released in Kanban Board Aug 21, 2019
@gergelyszabo94 gergelyszabo94 removed this from Released in Kanban Board Sep 1, 2019
@gergelyszabo94 gergelyszabo94 added this to To do in Kanban Board Oct 9, 2019
@gergelyszabo94 gergelyszabo94 removed this from To do in Kanban Board Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gergelyszabo94 gergelyszabo94

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gergelyszabo94