Gergo Erdosi
gergoerdosi

  • Ideapod
  • Budapest, Hungary
  • Joined on Aug 20, 2010

Organizations

@ideas @nesive
Jun 21, 2016
gergoerdosi commented on issue hapijs/hapi#437
@gergoerdosi

@pablocarreraest: The repository is here: https://github.com/hapijs/travelogue. The README says: This module is no longer being maintained. There …

Jun 14, 2016
gergoerdosi commented on issue hapijs/contrib#88
@gergoerdosi

Quick update: 51 of 63 modules support node v6. 🎉 7 modules just require a release (@stongo, @lloydbenson, @ulrikaugustsson, @osukaa, @jaw187, @M…

Jun 13, 2016
gergoerdosi commented on pull request hapijs/bell#214
@gergoerdosi

You need to add tests similarly to the other providers: https://github.com/hapijs/bell/tree/master/test/providers

Jun 9, 2016
gergoerdosi commented on pull request hapijs/subtext#31
@gergoerdosi

As I can see you added iltorb to dependencies which has a dependency on nan. So this part of the Travis output might be relevant: Starting with io…

Jun 8, 2016
gergoerdosi commented on pull request hapijs/lab#601
@gergoerdosi

I agree, would be good to use an extension. Eslint deprecated .eslintrc too in favor of .eslintrc.json, .eslintrc.yaml, etc.

Jun 7, 2016
gergoerdosi opened pull request hapijs/hapijs.com#394
@gergoerdosi
Unpublish hapi-json-view, hapi-mailer, and hapi-cloudinary-connector
1 commit with 0 additions and 12 deletions
Jun 7, 2016
@gergoerdosi
  • @gergoerdosi 0bbe9e4
    Unpublish hapi-json-view, hapi-mailer, and hapi-cloudinary-connector
Jun 7, 2016
Jun 7, 2016
gergoerdosi commented on pull request hapijs/wreck#137
@gergoerdosi

It's the latest version of the package that was published on npm.

May 28, 2016
gergoerdosi commented on pull request hapijs/hoek#188
@gergoerdosi

I think the implementation in hapi is because of request.reply(), where the first argument can be an error object, but also a valid data for the re…

May 27, 2016
gergoerdosi commented on pull request hapijs/good#495
May 26, 2016
gergoerdosi commented on issue hapijs/hapi#3024
@gergoerdosi

@devinivy: Thanks. I actually solved this problem with #3057, so I don't need the server state anymore. But it might still make sense to make the s…

May 26, 2016
gergoerdosi commented on pull request hapijs/bell#221
@gergoerdosi

I don't see deep being used anywhere in the code. Which files are you referring to?

May 25, 2016
gergoerdosi commented on pull request hapijs/bell#221
@gergoerdosi

@tameraydin: Remove deep in tests, it's the default in code v3.0.0.

May 24, 2016
gergoerdosi opened pull request hapijs/scooter#33
@gergoerdosi
Test on node v6, update dependencies
1 commit with 5 additions and 6 deletions
May 24, 2016
May 23, 2016
gergoerdosi commented on pull request hapijs/bell#221
@gergoerdosi

I think the name getMethod is a bit confusing. Method has a meaning in requests and this setting has nothing to do with that.

May 23, 2016
gergoerdosi commented on issue hapijs/nes#130
May 23, 2016
gergoerdosi commented on pull request hapijs/scooter#31
@gergoerdosi

@danielb2: Any news on this PR?

May 23, 2016
gergoerdosi commented on pull request hapijs/hapi-auth-hawk#26
@gergoerdosi

Ping @dannycoates.

May 23, 2016
gergoerdosi commented on pull request hapijs/tv#130
@gergoerdosi

No, sorry. I fetched your branch, but forgot to switch to it. I get locally what is on Travis: $ npm test > tv@5.0.2 test /Users/Gergo/Workspace/ha…

May 22, 2016
@gergoerdosi
Resources side panel has spaces in links
May 22, 2016
gergoerdosi commented on issue hapijs/hapi#3175
@gergoerdosi

Look at the boilerplates: http://hapijs.com/resources#Boilerplates. There are examples for React, Angular, etc.

May 22, 2016
gergoerdosi commented on issue hapijs/lab#590
@gergoerdosi

You can also just add Reflect to the ignored list of globals: --ignore 'Reflect'.

May 21, 2016
gergoerdosi commented on pull request hapijs/tv#130
@gergoerdosi

What's the issue exactly with PhatomJS? I wanted to look into this, but tests run fine locally: Gergo:tv Gergo$ node -v v4.4.4 Gergo:tv Gergo$ npm …

May 21, 2016
May 20, 2016
gergoerdosi commented on pull request hapijs/statehood#20
@gergoerdosi

Yes, makes sense to use code v3 instead of these prototype options. However I think this line will still make the test fail even on v3: https://git…

May 20, 2016
gergoerdosi commented on pull request hapijs/tv#130
@gergoerdosi

Any news on this PR?