Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip dot before extension, correct arg ordering #3

Merged
merged 1 commit into from Jan 23, 2020
Merged

Strip dot before extension, correct arg ordering #3

merged 1 commit into from Jan 23, 2020

Conversation

slifin
Copy link
Collaborator

@slifin slifin commented Jan 22, 2020 •
edited

Fixes argument passing to kondo to enable language passing

I've tested this change for .cljs .clj and .edn

aviflax
aviflax approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@aviflax aviflax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Phew, I’m glad you tested my change before shipping it!

@gerred
Copy link
Owner

gerred commented Jan 23, 2020

😅 nice catch.

@gerred gerred merged commit 8d1aa8e into gerred:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviflax aviflax aviflax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slifin @gerred @aviflax