Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker multi-stage build for optimal images #49

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@geshan
Copy link
Owner

geshan commented Nov 23, 2019

  • Remove nodemon from production
  • Add dev dependencies to dev
  • Add target to docker comopse and update version to 3.5
  • Decrease production image by 4 Mb
- [x] Remove nodemon from production
- [x] Add dev dependencies to dev
- [x] Add target to docker comopse and update version to 3.5
- [x] Decrease production image by 4 Mb
@now

This comment has been minimized.

Copy link

now bot commented Nov 23, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/geshanm/currency-api/qf3cf1c9m
🌍 Preview: https://currency-api-git-multi-stage-build.geshanm.now.sh

@geshan geshan merged commit 3c2ccd4 into master Nov 23, 2019
7 checks passed
7 checks passed
ci/dockercloud Your tests passed in Docker Cloud
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (63% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
now Deployment has completed
Details
@geshan geshan deleted the multi-stage-build branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.