Skip CLA check for get-convex organization members #836

Copilot · 2025-10-27T20:12:28Z

Original prompt

This section details on the original issue you should resolve

<issue_title>Modify scripts/check_cla.py to ignore members of the get-convex GitHub organization</issue_title>
<issue_description>https://github.com/get-convex/convex-helpers/blob/main/.github/workflows/cla.yml calls https://github.com/get-convex/convex-helpers/blob/main/scripts/check_cla.py.

It’s not required to do this check for members of the get-convex GitHub organization. To fix this:

Modify https://github.com/get-convex/convex-helpers/blob/main/.github/workflows/cla.yml to pass the GitHub username of the PR author as a new environment variable

Modify https://github.com/get-convex/convex-helpers/blob/main/scripts/check_cla.py to fetch the list of members of the get-convex GitHub organization.

If the user is a member of the GitHub organization, then skip the usual validation. (Log an appropriate message in the console to explain that validation was skipped because the user works for Convex)

If the user is NOT a member of get-convex, proceed as usual (i.e. verify that the PR description contains the CLA text)

If the list of users can't be fetched, log a warning in the console, then proceed as usual</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Modify scripts/check_cla.py to ignore members of the get-convex GitHub organization #835

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

… 404 handling Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Nicolapps · 2025-10-27T20:27:32Z

scripts/check_cla.py

+        elif member_status is None:
+            print(f"Warning: Could not verify organization membership for {PR_AUTHOR}. Proceeding with CLA check.")
+    else:
+        print("Warning: PR_AUTHOR environment variable not set. Proceeding with CLA check.")


If PR_AUTHOR is not set, we should throw an error here.

Done in fe085e7. The script now exits with an error if PR_AUTHOR is not set.

Nicolapps · 2025-10-27T20:27:50Z

scripts/check_cla.py

+        )
+        sys.exit(1)
+
+    print("CLA text found in PR description")


Can you please add emojis to the output? e.g. ✅, ❌

Done in fe085e7. Added emojis throughout: ✅ for success, ❌ for errors, and ⚠️ for warnings.

Nicolapps · 2025-10-27T20:28:06Z

scripts/check_cla.py

+        member_status = is_org_member(PR_AUTHOR, GITHUB_TOKEN)
+
+        if member_status is True:
+            print(f"Skipping CLA check: {PR_AUTHOR} is a member of the {ORGANIZATION} organization (Convex employee)")


Suggested change

print(f"Skipping CLA check: {PR_AUTHOR} is a member of the {ORGANIZATION} organization (Convex employee)")

print(f"Skipping CLA check: {PR_AUTHOR} is a member of the {ORGANIZATION} organization (Convex employee/contractor)")

Done in fe085e7. Updated the message to include "Convex employee/contractor".

Nicolapps · 2025-10-27T20:48:48Z

@copilot Address the comments

…mployee text Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Copilot · 2025-10-27T20:52:11Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/orgs/get-convex/members/external-contributor
- Triggering command: python3 /home/REDACTED/work/convex-helpers/convex-helpers/scripts/check_cla.py (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Nicolapps · 2025-10-27T20:52:54Z

scripts/check_cla.py

+        except urllib.error.HTTPError as e:
+            if e.code == 404:
+                # Cannot determine membership - could be private or user is not a member
+                return None


@copilot Shouldn’t this be False? I don't want a warning in that case

Fixed in 695ee7c. Now returns False for 404 responses (non-members) so no warning is shown. Only None (API failures like 403, network errors) triggers the warning message.

…members Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Copilot · 2025-10-27T20:56:55Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/orgs/get-convex/members/definitely-not-a-member-12345
- Triggering command: python3 /home/REDACTED/work/convex-helpers/convex-helpers/scripts/check_cla.py (http block)
- Triggering command: python3 /tmp/debug_api.py (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

e27accc

Copilot AI assigned Copilot and Nicolapps Oct 27, 2025

Copilot started work on behalf of Nicolapps October 27, 2025 20:12 View session

Copilot AI and others added 3 commits October 27, 2025 20:18

Implement CLA check skip for get-convex organization members

e0ce143

Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Add missing urllib.error import

05d032b

Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Address code review comments: improve import organization and clarify…

6201717

… 404 handling Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Modify check_cla.py to ignore get-convex organization members~~ Skip CLA check for get-convex organization members Oct 27, 2025

Copilot AI requested a review from Nicolapps October 27, 2025 20:24

Copilot finished work on behalf of Nicolapps October 27, 2025 20:24

Nicolapps requested changes Oct 27, 2025

View reviewed changes

Copilot started work on behalf of Nicolapps October 27, 2025 20:49 View session

Address PR feedback: add emojis, error on missing PR_AUTHOR, update e…

fe085e7

…mployee text Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Copilot AI requested a review from Nicolapps October 27, 2025 20:52

Copilot finished work on behalf of Nicolapps October 27, 2025 20:52

Nicolapps reviewed Oct 27, 2025

View reviewed changes

Copilot started work on behalf of Nicolapps October 27, 2025 20:53 View session

Return False for 404 responses to avoid unnecessary warnings for non-…

695ee7c

…members Co-authored-by: Nicolapps <7029582+Nicolapps@users.noreply.github.com>

Copilot AI requested a review from Nicolapps October 27, 2025 20:57

Copilot finished work on behalf of Nicolapps October 27, 2025 20:57

Nicolapps approved these changes Oct 27, 2025

View reviewed changes

Nicolapps marked this pull request as ready for review October 27, 2025 20:58

Nicolapps merged commit 3a0cf08 into main Oct 27, 2025
3 checks passed

Nicolapps deleted the copilot/modify-check-cla-ignore-members branch October 27, 2025 20:59

Nicolapps mentioned this pull request Oct 27, 2025

Improve documentation of Zod #824

Merged

	print(f"Skipping CLA check: {PR_AUTHOR} is a member of the {ORGANIZATION} organization (Convex employee)")
	print(f"Skipping CLA check: {PR_AUTHOR} is a member of the {ORGANIZATION} organization (Convex employee/contractor)")

Skip CLA check for get-convex organization members #836

Skip CLA check for get-convex organization members #836

Conversation

Copilot AI commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

Nicolapps Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Nicolapps Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Nicolapps Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Nicolapps commented Oct 27, 2025

Uh oh!

Copilot AI commented Oct 27, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Nicolapps Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 27, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 27, 2025 •

edited

Loading