Skip to content

Conversation

@ar3s3ru
Copy link
Collaborator

@ar3s3ru ar3s3ru commented Sep 3, 2021

This PR re-introduces support for subscription.Volatile, by adding support for a new Event Store interface: eventstore.SequenceNumberGetter.

With this interface, we can retrieve the latest sequence number value for the Event Store, and use a Catch-up Subscription that starts consuming from this value. Checkpoints should be disabled, as Volatile Subscriptions are meant not to carry state.

@ar3s3ru ar3s3ru enabled auto-merge (squash) September 3, 2021 20:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.1% 62.1% Coverage
0.0% 0.0% Duplication

@ar3s3ru ar3s3ru merged commit 6da801f into main Sep 3, 2021
@ar3s3ru ar3s3ru deleted the re-enable-volatile-subscription branch September 3, 2021 20:40
@ar3s3ru ar3s3ru linked an issue Sep 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: re-enable support for Volatile Subscriptions

2 participants