[Changes Requested] Maven plugin for appmap java recorder #46

marcuss · 2021-01-30T05:54:23Z

No description provided.

…ing process.

kgilpin · 2021-02-02T01:55:51Z

Is there a spec for this @ptrdvrk ? My understanding was that we wanted to have the maven plugin add the Java agent to the jvm args. A command to make a recording could be interesting but the primary means for making recordings is running tests.

kgilpin · 2021-02-02T01:56:37Z

@marcuss It seems that a part of this PR would be to publish to maven central? Or a related PR.

ptrdvrk · 2021-02-02T02:28:08Z

@kgilpin the functional spec is here: https://docs.google.com/document/d/147EDYpBh1xdEw6KUaC1L2W3qmemC0mJPE5GgrK_iwmo/edit#heading=h.14ya0r1ubmbk
You are correct. The plugin is expected to enable instrumentation, not to start/stop recording.
@marcuss let's review that. The plugin needs to load the appmap.jar, which will trigger the instrumentation to be started via the premain static method (see the jar manifest); and pass the required parameters to it.

marcuss · 2021-02-02T15:07:04Z

@ptrdvrk this is still a work in progress, I will check the functional spec I had lost the link to it and make the necessary adjustments.

marcuss · 2021-02-02T20:32:58Z

@kgilpin @ptrdvrk
Is it ok for me to keep this draft PR open while I add the missing functionality? I ask because I don't want this to look like the current state is the way I'm going to deliver the project, for me is just a way to show some progress since there is a small amount of time allocated each day for the task.

marcuss · 2021-02-02T20:34:11Z

@dustinbyrne is this normal https://travis-ci.com/github/applandinc/appmap-java/jobs/479726666 ?

appmap-java-maven-plugin/src/main/java/com/appland/appmap/LoadJavaAppMapAgentMojo.java

…cal spec document demands.

marcuss · 2021-02-03T04:45:42Z

First working version using console commands to load the agent. (needs a lot of refactoring)

marcuss · 2021-02-05T21:00:46Z

As per yesterday, I changed the project to work without any EPL portion of code and made all the options work as expected including one for skip execution of the agent.

appmap-java-maven-plugin/src/main/java/com/appland/appmap/LoadJavaAppMapAgentMojo.java

Fixed issue with preexistent command line. Minor Refactor.

appmap-java-maven-plugin/README.md

appmap-java-maven-plugin/pom.xml

marcuss · 2021-02-22T23:29:28Z

Added requested changes on xbootclasspath issue.

dustinbyrne

This looks great @marcuss, thank you for the hard work you've put into this. I've added a few naming related comments, then we're good to merge!

appmap-java-maven-plugin/README.md

appmap-java-maven-plugin/pom.xml

appmap-java-maven-plugin/src/main/java/com/appland/appmap/AppMapAgentMojo.java

marcuss · 2021-02-25T02:05:24Z

@dustinbyrne is a bigger change, but... should I also change the folder name from
appmap-java-maven-plugin>

to

appmap-agent-maven-plugin ?

…t is a maven plugin.

marcuss

I went down the rabbit hole for 2 hours, still not even compiling in my machine.
researching could be related to java 8 and adding new dependencies to the pom
the fact that I could use it during all this time may be related to maven repo cache..

I will continue to work on this tomorrow.

marcuss · 2021-02-25T02:07:44Z

appmap-java-maven-plugin/pom.xml

+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <groupId>org.appland</groupId>
+    <artifactId>appmap-java-maven-plugin</artifactId>


@dustinbyrne appmap-maven-plugin ?

removed java 8 dependencies, now the project can be compiled with java 1.7

dustinbyrne

💯

feat: AppMap Maven plugin (getappmap#46)

# 1.0.0 (2021-03-16) ### Features * AppMap Maven plugin ([#46](#46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

# 1.0.0 (2021-03-17) ### Features * AppMap Maven plugin ([#46](#46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

appland-release · 2021-03-17T05:17:07Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

v1.0.0
GitHub release

Your semantic-release bot 📦🚀

# 1.0.0 (2021-04-13) ### Bug Fixes * **gradle:** add debugging output ([8b63cfa](8b63cfa)) * **gradle:** add debugging output ([e577d30](e577d30)) * **gradle:** alternative way of specifying nexus credentials ([2df78dd](2df78dd)) * **gradle:** alternative way of specifying nexus credentials ([a018510](a018510)) * **gradle:** broken gradle directives ([b529ea2](b529ea2)) * **gradle:** fix typo ([7d11ffa](7d11ffa)) * **gradle:** troubleshoot testenv ([80e7b29](80e7b29)) * **gradle:** troubleshoot testenv ([5c16f70](5c16f70)) * Allow classes compiled without locals to be hooked ([0e0a0d3](0e0a0d3)) * Capture exceptions thrown from SQL interfaces ([9d1e66f](9d1e66f)) * disable http client requests ([getappmap#60](https://github.com/hleb-rubanau/appmap-java/issues/60)) ([2131d82](2131d82)) * Don't append System path to class pools ([681d74e](681d74e)) * improve path and package resolution ([getappmap#62](https://github.com/hleb-rubanau/appmap-java/issues/62)) ([c3ba3df](c3ba3df)) * Provide better error message when encountering an unknown event ([c69a877](c69a877)) ### Features * **docs:** improve CI documentation and also trigger the relase ([e6b5a8e](e6b5a8e)) * AppMap Maven plugin ([getappmap#46](https://github.com/hleb-rubanau/appmap-java/issues/46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

marcuss added 4 commits January 29, 2021 22:40

Initial version of java map plugin.

78c39f1

Trying to register a java recorder by code from within the plugin mojo.

1692b04

Adding the missing agent library so the plugin can fire up the record…

51c1cb7

…ing process.

First Attempt to add proper test to the maven dependency project.

a3df52e

Renaming project artifacts to adhere to tech specs.

02e18fd

ptrdvrk suggested changes Feb 2, 2021

View reviewed changes

appmap-java-maven-plugin/src/main/java/com/appland/appmap/LoadJavaAppMapAgentMojo.java Show resolved Hide resolved

First working version of the AppMap plugin being loaded as per techni…

909bbce

…cal spec document demands.

marcuss added 3 commits February 3, 2021 22:10

Minor refactor of the working command line version.

95a78b9

Minor refactor of the working command line version.

f021384

Maven Plugin for AppMap Java Agent.

4caa606

marcuss marked this pull request as ready for review February 5, 2021 05:16

ptrdvrk reviewed Feb 5, 2021

View reviewed changes

appmap-java-maven-plugin/src/main/java/com/appland/appmap/LoadJavaAppMapAgentMojo.java Outdated Show resolved Hide resolved

Added README.md file.

d93311b

Fixed issue with preexistent command line. Minor Refactor.

kgilpin reviewed Feb 15, 2021

View reviewed changes

appmap-java-maven-plugin/README.md Outdated Show resolved Hide resolved

dustinbyrne requested changes Feb 17, 2021

View reviewed changes

appmap-java-maven-plugin/pom.xml Outdated Show resolved Hide resolved

marcuss changed the title ~~Maven plugin for appmap java recorder~~ [Ready to Merge] Maven plugin for appmap java recorder Feb 21, 2021

dustinbyrne requested changes Feb 24, 2021

View reviewed changes

marcuss changed the title ~~[Ready to Merge] Maven plugin for appmap java recorder~~ [Changes Requested] Maven plugin for appmap java recorder Feb 25, 2021

Changes as requested in code review. drop the java identifier since i…

aded373

…t is a maven plugin.

marcuss force-pushed the maven-plugin-appmap-java branch from 854fecf to aded373 Compare February 25, 2021 03:29

marcuss commented Feb 25, 2021

View reviewed changes

marcuss added 2 commits February 24, 2021 22:44

changed as requested during code review PR

1581894

Fixed build issue.

33849a8

removed java 8 dependencies, now the project can be compiled with java 1.7

dustinbyrne requested review from dustinbyrne and ptrdvrk February 25, 2021 17:17

dustinbyrne approved these changes Feb 25, 2021

View reviewed changes

dustinbyrne merged commit 1798df2 into getappmap:master Feb 25, 2021

marcuss added a commit to marcuss/appmap-java that referenced this pull request Feb 26, 2021

Merge pull request #1 from applandinc/master

3409ec9

feat: AppMap Maven plugin (getappmap#46)

appland-release pushed a commit that referenced this pull request Mar 16, 2021

chore(release): 1.0.0 [skip ci]

73378d2

# 1.0.0 (2021-03-16) ### Features * AppMap Maven plugin ([#46](#46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

appland-release pushed a commit that referenced this pull request Mar 17, 2021

chore(release): 1.0.0 [skip ci]

cefad2a

# 1.0.0 (2021-03-17) ### Features * AppMap Maven plugin ([#46](#46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

appland-release pushed a commit that referenced this pull request Mar 17, 2021

chore(release): 1.0.0 [skip ci]

f8202dc

# 1.0.0 (2021-03-17) ### Features * AppMap Maven plugin ([#46](#46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

appland-release pushed a commit that referenced this pull request Mar 17, 2021

chore(release): 1.0.0 [skip ci]

1c99f12

# 1.0.0 (2021-03-17) ### Features * AppMap Maven plugin ([#46](#46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))

appland-release added the released label Mar 17, 2021

[Changes Requested] Maven plugin for appmap java recorder #46

[Changes Requested] Maven plugin for appmap java recorder #46

Uh oh!

Conversation

marcuss commented Jan 30, 2021

Uh oh!

kgilpin commented Feb 2, 2021

Uh oh!

kgilpin commented Feb 2, 2021

Uh oh!

ptrdvrk commented Feb 2, 2021

Uh oh!

marcuss commented Feb 2, 2021

Uh oh!

marcuss commented Feb 2, 2021

Uh oh!

marcuss commented Feb 2, 2021

Uh oh!

Uh oh!

marcuss commented Feb 3, 2021

Uh oh!

marcuss commented Feb 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcuss commented Feb 22, 2021

Uh oh!

dustinbyrne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcuss commented Feb 25, 2021

Uh oh!

marcuss left a comment

Choose a reason for hiding this comment

Uh oh!

marcuss Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dustinbyrne left a comment

Choose a reason for hiding this comment

Uh oh!

appland-release commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcuss Feb 25, 2021 •

edited

Loading