Skip to content

fix: disable http client requests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustinbyrne merged 1 commit into from
Mar 17, 2021
Merged

fix: disable http client requests #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/main/java/com/appland/appmap/process/hooks/HttpClientRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@
@Unique("http_client_request")
public class HttpClientRequest {

private static final Recorder recorder = Recorder.getInstance();
private static final Recorder recorder = Recorder.getInstance();

@HookClass(value = "java.net.HttpURLConnection")
public static void connect(Event event, HttpURLConnection httpURLConnection) {
//TODO: ReflectiveType can be used with HttpURLConnection
URL url = httpURLConnection.getURL();
event.setHttpClientRequest(httpURLConnection.getRequestMethod(), url.getHost(), url.getProtocol());
recorder.add(event);
}
// @HookClass(value = "java.net.HttpURLConnection")
public static void connect(Event event, HttpURLConnection httpURLConnection) {
//TODO: ReflectiveType can be used with HttpURLConnection
URL url = httpURLConnection.getURL();
event.setHttpClientRequest(httpURLConnection.getRequestMethod(), url.getHost(), url.getProtocol());
recorder.add(event);
}

@CallbackOn(MethodEvent.METHOD_RETURN)
@HookClass(value = "java.net.HttpURLConnection")
public static void connect(Event event, HttpURLConnection httpURLConnection, Object ret) throws IOException {
event.setHttpClientResponse(httpURLConnection.getResponseCode(), httpURLConnection.getContentType());
recorder.add(event);
}
// @CallbackOn(MethodEvent.METHOD_RETURN)
// @HookClass(value = "java.net.HttpURLConnection")
public static void connect(Event event, HttpURLConnection httpURLConnection, Object ret) throws IOException {
event.setHttpClientResponse(httpURLConnection.getResponseCode(), httpURLConnection.getContentType());
recorder.add(event);
}

}
3 changes: 2 additions & 1 deletion test/smoke.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ load 'helper'
}

@test "expected number of http client events captured" {
skip

java_version=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed 's/^1\.//'| cut -d'.' -f1 | cut -d'-' -f1)
if [ $java_version -gt "8" ]; then
Expand All @@ -138,4 +139,4 @@ load 'helper'
output=$(</tmp/appmap/*.appmap.json)
assert_json_eq '[.events[] | select(.http_client_request)] | length' 3
assert_json_eq '[.events[] | select(.http_client_response)] | length' 3
}
}