Remove cursor: pointer from code #122

Closed
xavez opened this Issue Jul 17, 2016 · 5 comments

Projects

None yet

4 participants

@xavez
Member
xavez commented Jul 17, 2016

Applying cursor: pointer to all clickable elements might be harmful. Read more here: https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b#.7yzskuopw

cursor: pointer is currently applied to:

  • Everything with the .c-button class
  • <label>s
  • <legend>s

I think we can remove it from <label>s and <legend>s without much discussion

The case of .c-button is possibly a bit more complex. For instance: <button class="c-button">s which do not naturally have a hand cursor, also get a hand cursor. This is not good. If anything, it should be the other way around: .c-buttons always get a cursor: default. But then there are edge cases there as well.

I would propose to remove those lines of code and let the browser decide when to apply which cursor. I think they are unnecessary in the boilerplate code of chopstick.

@xavez xavez added the question label Jul 18, 2016
@xavez
Member
xavez commented Aug 1, 2016

Anyone has input / views on this?

@Dietr
Member
Dietr commented Aug 1, 2016

Good point. Maybe adding cursor: default to buttons also makes some sense?

@Wolfr
Wolfr commented Aug 2, 2016

Imho - don't mess with the browser defaults. Remove all of it.

@simoncoudeville
Contributor

Isn't cursor: default the same as removing cursor? Nevertheless I'm also in favor of removing cursor: pointer.

@xavez xavez self-assigned this Sep 12, 2016
@xavez
Member
xavez commented Sep 12, 2016

OK, I’ll make a PR

@xavez xavez added enhancement and removed question labels Sep 12, 2016
@Dietr Dietr closed this in #135 Sep 21, 2016
@xavez xavez added a commit that referenced this issue Oct 3, 2016
@xavez xavez Merge branch 'master' into feature/remove-bower
* master:
  Favicon sketch & icon-slate template (#136)
  linter: exclude the charset statement from the test as it needs double quotes
  fix: elements.page.scss was present in this repo but the bower version was used
  Alerts: remove cursor setting entirely, as described in #122
  Alerts: closing an alert displays default cursor, see #122
  Buttons: remove cursor: pointer, see #122
9571afb
@Dietr Dietr added a commit that referenced this issue Oct 19, 2016
@Dietr Dietr Merge branch 'master' into gh-pages
* master: (61 commits)
  remove chopstick layers, add chopstick sass, update sceen.scss and settings
  CONTRIBUTIN.md has more consistent text casing
  Feature/svg icons (#140)
  Remove modernizr
  Bump nvm version
  Update CONTRIBUTING.md
  add pretty permalinks, fixes #132
  fixes #138
  Favicon sketch & icon-slate template (#136)
  linter: exclude the charset statement from the test as it needs double quotes
  fix: elements.page.scss was present in this repo but the bower version was used
  Alerts: remove cursor setting entirely, as described in #122
  Alerts: closing an alert displays default cursor, see #122
  Buttons: remove cursor: pointer, see #122
  Generate navigation in components.nav-main.html (#129)
  fixes #126
  Remove respondjs, fixes #124
  Remove partials info from README.md, fixes #120
  Further refinements to README.md, see #120
  Further simplification of README.md, see #120
  ...
602dc19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment