Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFactor out consul setup and health check #11
Merged
Conversation
Putting them in standalone scripts means that a user of this module can run the same code that gets run by the automated tests, so the user can run the consul configuration and health checks that are known to work.
This comment has been minimized.
This comment has been minimized.
|
Ran the service tests with and without datadog and sslmate set, and they're all good! |
This comment has been minimized.
This comment has been minimized.
|
For the record, the command I ran was: With and without the environment variables set that turn on datadog or sslmate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sverch commentedNov 15, 2018
Putting them in standalone scripts means that a user of this module can run the same code that gets run by the automated tests, so the user can run the consul configuration and health checks that are known to work.