Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out consul setup and health check #11

Merged
merged 1 commit into from Nov 16, 2018
Merged

Factor out consul setup and health check #11

merged 1 commit into from Nov 16, 2018

Conversation

@sverch
Copy link
Contributor

sverch commented Nov 15, 2018

Putting them in standalone scripts means that a user of this module can run the same code that gets run by the automated tests, so the user can run the consul configuration and health checks that are known to work.

@sverch sverch force-pushed the consul-setup-helper branch from e888fc8 to 121af40 Nov 15, 2018
Putting them in standalone scripts means that a user of this module can
run the same code that gets run by the automated tests, so the user can
run the consul configuration and health checks that are known to work.
@sverch sverch force-pushed the consul-setup-helper branch from 121af40 to 7b0d61d Nov 16, 2018
@sverch

This comment has been minimized.

Copy link
Contributor Author

sverch commented Nov 16, 2018

Ran the service tests with and without datadog and sslmate set, and they're all good!

@sverch sverch merged commit 3c308cc into master Nov 16, 2018
@sverch sverch deleted the consul-setup-helper branch Nov 16, 2018
@sverch

This comment has been minimized.

Copy link
Contributor Author

sverch commented Nov 16, 2018

For the record, the command I ran was:

cldls service-test run service_test_configuration.yml

With and without the environment variables set that turn on datadog or sslmate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.