Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type validation #1405

Merged
merged 4 commits into from Apr 10, 2023
Merged

fix: type validation #1405

merged 4 commits into from Apr 10, 2023

Conversation

chloeminkyung
Copy link
Contributor

fix: type validation

Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chloeminkyung chloeminkyung linked an issue Apr 10, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Apr 10, 2023

Pull Request Test Coverage Report for Build 4657424360

  • 157 of 157 (100.0%) changed or added relevant lines in 2 files are covered.
  • 272 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.6%) to 77.196%

Files with Coverage Reduction New Missed Lines %
dozer-api/src/grpc/shared_impl/filter/mod.rs 1 91.89%
dozer-api/src/grpc/shared_impl/mod.rs 1 85.37%
dozer-cache/src/cache/expression/query_serde.rs 2 98.8%
dozer-sql/src/pipeline/product/join/processor.rs 2 95.56%
dozer-api/src/grpc/typed/service.rs 3 79.61%
dozer-api/src/grpc/typed/tests/service.rs 4 97.03%
dozer-core/src/errors.rs 4 44.44%
dozer-types/src/models/app_config.rs 6 96.77%
dozer-core/src/epoch.rs 11 91.73%
dozer-orchestrator/src/simple/orchestrator.rs 18 73.74%
Totals Coverage Status
Change from base Build 4655278666: 0.6%
Covered Lines: 34721
Relevant Lines: 44978

💛 - Coveralls

dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
dozer-sql/src/pipeline/expression/comparison.rs Outdated Show resolved Hide resolved
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@mediuminvader mediuminvader merged commit 8e313f0 into main Apr 10, 2023
5 checks passed
@mediuminvader mediuminvader deleted the fix/type-validation branch April 10, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type validation during comparison
4 participants