Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to respect MacOS light/dark theme #173

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@steliyan
Copy link
Contributor

steliyan commented Oct 30, 2019

Add an option to respect MacOS light/dark theme.

Description

It's a complementary change with the current dark mode and it's only implemented for MacOSX.
There is an additional checkbox that controls whether Ferdi should respect the current OS theme. It's disabled if the Join the Dark Side is enabled.

Motivation and Context

I use flux, which has an option to change to MacOSX's dark theme after sunset. Almost all applications I use are listening to the light -> dark transition (or vice versa), but not Ferdi.
It's my attempt to contribute to this great project. :)

How Has This Been Tested?

I've tested it by manually switching light/dark themes in System Preferences -> General.
NOTE: This change should not affect any users that are NOT running MacOSX.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project (run $ yarn lint).

Your feedback is welcomed. :))

Greetings, Steliyan.

@vantezzen

This comment has been minimized.

Copy link
Member

vantezzen commented Oct 30, 2019

@all-contributors add @steliyan for code, ideas

@allcontributors

This comment has been minimized.

Copy link
Contributor

allcontributors bot commented Oct 30, 2019

@vantezzen

I've put up a pull request to add @steliyan! 🎉

@vantezzen

This comment has been minimized.

Copy link
Member

vantezzen commented Oct 30, 2019

Awesome, thank you for your contribution! Looks good to me - should be shipped with the next build.

@vantezzen vantezzen merged commit c438111 into getferdi:develop Oct 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
vantezzen added a commit that referenced this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.