Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render 410 page when link has been used/expired #335

Merged
merged 2 commits into from Apr 5, 2018

Conversation

goenning
Copy link
Member

@goenning goenning commented Apr 5, 2018

Issue: closes #170

Introduces the 410 GONE page used for verification keys that have been user or expired

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f70ecbd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage          ?   72.84%           
=========================================
  Files             ?       71           
  Lines             ?     4511           
  Branches          ?        0           
=========================================
  Hits              ?     3286           
  Misses            ?      982           
  Partials          ?      243
Impacted Files Coverage Δ
app/pkg/web/context.go 80.09% <100%> (ø)
app/pkg/web/renderer.go 75.38% <100%> (ø)
app/handlers/common.go 84.85% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70ecbd...fa21564. Read the comment docs.

@goenning goenning merged commit c6caa5d into master Apr 5, 2018
@goenning goenning deleted the expired-links-410-gone branch April 24, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create page for expired/invalid sign in links instead of redirecting to home
2 participants