New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: correct use of OAuth state #450

Merged
merged 4 commits into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Jul 9, 2018

Issue: part of #441

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #450 into master will decrease coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #450      +/-   ##
=========================================
- Coverage   75.81%   75.8%   -0.02%     
=========================================
  Files          89      89              
  Lines        5925    5925              
=========================================
- Hits         4492    4491       -1     
- Misses       1119    1120       +1     
  Partials      314     314
Impacted Files Coverage Δ
app/pkg/web/context.go 89.45% <ø> (+0.9%) ⬆️
app/pkg/web/util/webutil.go 95.74% <100%> (ø)
app/middlewares/setup.go 61.59% <100%> (+0.28%) ⬆️
app/pkg/mock/oauth.go 96.67% <100%> (ø) ⬆️
app/pkg/env/env.go 98.65% <100%> (-0.12%) ⬇️
app/pkg/web/oauth.go 47.5% <71.43%> (ø) ⬆️
app/handlers/oauth.go 81.44% <85%> (-0.78%) ⬇️
app/pkg/web/engine.go 75.52% <0%> (-1.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a67053...fb43eba. Read the comment docs.

@goenning goenning merged commit ec49347 into master Jul 9, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the use-state-oauth branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment