New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new Google OAuth API #453

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Jul 11, 2018

Issue: part of #441

goenning added some commits Jul 11, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #453 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage    75.8%   75.81%   +0.01%     
==========================================
  Files          89       89              
  Lines        5925     5928       +3     
==========================================
+ Hits         4491     4494       +3     
  Misses       1120     1120              
  Partials      314      314
Impacted Files Coverage Δ
app/pkg/web/oauth.go 48.15% <100%> (+0.65%) ⬆️
app/pkg/jsonq/jsonq.go 84.29% <100%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb0ea6...459fcba. Read the comment docs.

@goenning goenning merged commit 879f846 into master Jul 11, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the update-google-oauth branch Jul 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment