New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send EHLO during SMTP connection #525

Merged
merged 5 commits into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Sep 5, 2018

Issue: fixes #501

goenning added some commits Sep 5, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 26, 2018

Codecov Report

Merging #525 into master will increase coverage by 0.08%.
The diff coverage is 17.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   74.39%   74.47%   +0.08%     
==========================================
  Files          97       97              
  Lines        6392     6389       -3     
==========================================
+ Hits         4755     4758       +3     
+ Misses       1296     1289       -7     
- Partials      341      342       +1
Impacted Files Coverage Δ
app/pkg/email/email.go 89.29% <ø> (ø) ⬆️
app/pkg/web/context.go 89.17% <100%> (ø) ⬆️
app/pkg/worker/context.go 87.76% <100%> (ø) ⬆️
app/pkg/email/smtp/smtp.go 16.15% <12.82%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f001dcf...ead55eb. Read the comment docs.

goenning added some commits Sep 26, 2018

@goenning goenning changed the title [WIP] fix: send EHLO during SMTP connection fix: send EHLO during SMTP connection Sep 26, 2018

@goenning goenning merged commit ef8aea8 into master Sep 26, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the hello-smtp branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment