New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooling: update to Go 1.11.1 and enable SameSite=Lax #552

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Oct 5, 2018

Issue: This is an attempt to #519 by enabling SameSite=Lax (reference chrome bug 696204)

Even if it doesn't fix the bug, it's good for security reasons and it's also a Go version bump.

closes #509

@goenning goenning changed the title tooling: update to Go 1.11.1 and enable Lax tooling: update to Go 1.11.1 and enable SameSite=Lax Oct 5, 2018

@goenning

This comment has been minimized.

Copy link
Member

goenning commented Oct 5, 2018

Looks like we're blocked with until 1.12 is released golang/go#26186

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #552 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   74.56%   74.55%   -0.01%     
==========================================
  Files          97       97              
  Lines        6391     6397       +6     
==========================================
+ Hits         4765     4769       +4     
- Misses       1284     1286       +2     
  Partials      342      342
Impacted Files Coverage Δ
app/pkg/web/context.go 88.52% <100%> (+0.09%) ⬆️
app/pkg/web/util/webutil.go 96.15% <100%> (+0.15%) ⬆️
app/pkg/email/smtp/smtp.go 16.03% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c81da...3891da3. Read the comment docs.

@goenning goenning merged commit 845fdc3 into master Oct 5, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the tooling-update-go-1-11 branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment