New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add sitemap.xml #558

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Oct 8, 2018

  • Add a dynamic (and very basic) sitemap to every root site.;
  • Private sites will not generate a sitemap.xml;
  • Sitemap does not yet include other pages aside from homepage and all posts;
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #558 into master will increase coverage by 0.08%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage    74.4%   74.48%   +0.08%     
==========================================
  Files          99       99              
  Lines        6454     6474      +20     
==========================================
+ Hits         4802     4822      +20     
+ Misses       1308     1307       -1     
- Partials      344      345       +1
Impacted Files Coverage Δ
app/pkg/web/context.go 88.62% <100%> (+0.09%) ⬆️
app/cmd/routes.go 86.96% <100%> (+0.11%) ⬆️
app/handlers/common.go 87.93% <88.24%> (+0.13%) ⬆️
app/storage/inmemory/post.go 89.78% <0%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6a3c6...ee4ac65. Read the comment docs.

@goenning goenning merged commit 9353e75 into master Oct 8, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the add-sitemap branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment