Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow support of Office 365 #584
This allow fider user's to set
Office 365 SMTP use "LOGIN Simple Authentication" defined by this Internet Draft: draft-murchison-sasl-login-00.txt.
@@ Coverage Diff @@ ## master #584 +/- ## ========================================== - Coverage 74.35% 74.06% -0.29% ========================================== Files 103 105 +2 Lines 6631 6695 +64 ========================================== + Hits 4930 4958 +28 - Misses 1340 1376 +36 Partials 361 361
That looks great, thank you @oxynux
I have a suggestion if you don't mind. I'd like to avoid the extra environment variable and I believe it's possible.
The gotsmtp.ServerInfo has an
By avoiding the extra parameter we make it flexible and easier for the end user :)
@oxynux that's great! I didn't know that Go smtp had support for CRAMMD5Auth. So this PR will fix a bug and introduce a feature, great job
I have my last two request, hope you don't get angry at me
We should remove that duplicate code of initialising the Auth's twice + calling
If we extract the logic to find the correct auth into a new function, like.
We also need to cover AgnosticAuth with simple unit tests. The ones I can think about is:
Awesome! That's exactly what I was thinking about
As for the test, you can create a
The second test you can start like the first, but set