New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: UTC changed to local time #602

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@Mygeen
Copy link
Contributor

Mygeen commented Oct 28, 2018

Issue: Unit test was using UTC comparing to local time. Therefore, the test failed in time zone UTC +1.

I edited the test values of the failing unit test to use local time instead of UTC.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 28, 2018

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   74.98%   74.98%           
=======================================
  Files         100      100           
  Lines        6431     6431           
=======================================
  Hits         4822     4822           
  Misses       1262     1262           
  Partials      347      347

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab30ea...b5f52ca. Read the comment docs.

@Mygeen Mygeen changed the title UTC to local time Unit tests: UTC to local time Oct 28, 2018

@Mygeen Mygeen changed the title Unit tests: UTC to local time Unit tests: UTC changed to local time Oct 28, 2018

@goenning goenning merged commit 9e8466e into getfider:master Oct 29, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details
@goenning

This comment has been minimized.

Copy link
Member

goenning commented Oct 29, 2018

Nice one! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment