New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: create page for browser not supported #620

merged 3 commits into from Nov 3, 2018


None yet
2 participants
Copy link

goenning commented Nov 3, 2018

We redirect users to /browser-not-support on two occasions:

  • IE <=10
  • Any browser that support only CSP 1 (and not CSP 2), like Chrome ~30 or older. These browsers fails to run inline script with nonce, thus failing Fider.initialize as well.

This comment has been minimized.

Copy link

codecov-io commented Nov 3, 2018

Codecov Report

Merging #620 into master will decrease coverage by 0.05%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #620      +/-   ##
- Coverage   74.92%   74.87%   -0.05%     
  Files         100      100              
  Lines        6423     6430       +7     
+ Hits         4812     4814       +2     
- Misses       1260     1264       +4     
- Partials      351      352       +1
Impacted Files Coverage Δ
app/cmd/routes.go 87.29% <100%> (+0.11%) ⬆️
app/handlers/common.go 72.37% <16.67%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886e912...b327d02. Read the comment docs.

goenning added some commits Nov 3, 2018

@goenning goenning merged commit 83baee9 into master Nov 3, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
ci/circleci: push Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test-server Your tests passed on CircleCI!
ci/circleci: test-ui Your tests passed on CircleCI!

@goenning goenning deleted the browser-not-supported-page branch Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment