New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: notify subscribers about posts being deleted #625

Merged
merged 3 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Nov 7, 2018

No description provided.

goenning added some commits Nov 7, 2018

@goenning goenning merged commit 0ae8d1a into master Nov 7, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #625 into master will increase coverage by 0.02%.
The diff coverage is 79.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   74.86%   74.88%   +0.02%     
==========================================
  Files         100      100              
  Lines        6429     6457      +28     
==========================================
+ Hits         4813     4835      +22     
- Misses       1264     1267       +3     
- Partials      352      355       +3
Impacted Files Coverage Δ
app/storage/postgres/post.go 84.03% <100%> (+0.61%) ⬆️
app/handlers/apiv1/post.go 59.44% <33.33%> (-0.84%) ⬇️
app/tasks/tasks.go 80.49% <73.91%> (-1.07%) ⬇️
app/storage/inmemory/post.go 85.42% <85.71%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004cadb...eccc791. Read the comment docs.

@goenning goenning deleted the notify-on-delete branch Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment