Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: replace semantic-ui with react icons #631

Merged
merged 12 commits into from Nov 10, 2018
Merged

Conversation

@goenning
Copy link
Member

@goenning goenning commented Nov 10, 2018

Issue: closes #554

@codecov-io
Copy link

@codecov-io codecov-io commented Nov 10, 2018

Codecov Report

Merging #631 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   74.95%   74.94%   -0.01%     
==========================================
  Files         100      100              
  Lines        6458     6456       -2     
==========================================
- Hits         4840     4838       -2     
  Misses       1264     1264              
  Partials      354      354
Impacted Files Coverage Δ
app/pkg/web/renderer.go 82.22% <ø> (-0.39%) ⬇️
main.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc4cd2...4c8ae45. Read the comment docs.

@goenning goenning merged commit e7cd2c1 into master Nov 10, 2018
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details
@goenning goenning deleted the use-react-icons branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants