Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooling: replace react-loadable with react lazy #646

Merged
merged 2 commits into from Nov 15, 2018
Merged

tooling: replace react-loadable with react lazy #646

merged 2 commits into from Nov 15, 2018

Conversation

@goenning
Copy link
Member

@goenning goenning commented Nov 15, 2018

Issue: part of #588

@goenning goenning mentioned this pull request Nov 15, 2018
6 of 6 tasks complete
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 15, 2018

Codecov Report

Merging #646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #646   +/-   ##
======================================
  Coverage    74.4%   74.4%           
======================================
  Files         103     103           
  Lines        6626    6626           
======================================
  Hits         4930    4930           
  Misses       1335    1335           
  Partials      361     361

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2c075...fa41e02. Read the comment docs.

@goenning goenning merged commit b7d3c09 into master Nov 15, 2018
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details
@goenning goenning deleted the use-react-lazy branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants