New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add API to return list of voters #654

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Nov 26, 2018

Issue: #550

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #654 into master will decrease coverage by 0.1%.
The diff coverage is 53.13%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #654     +/-   ##
========================================
- Coverage      74%   73.9%   -0.1%     
========================================
  Files         105     105             
  Lines        6700    6732     +32     
========================================
+ Hits         4958    4975     +17     
- Misses       1381    1394     +13     
- Partials      361     363      +2
Impacted Files Coverage Δ
app/storage/inmemory/post.go 84.25% <0%> (-1.17%) ⬇️
app/cmd/routes.go 87.8% <100%> (+0.1%) ⬆️
app/handlers/apiv1/post.go 53.05% <8.33%> (-3.53%) ⬇️
app/storage/postgres/post.go 85.04% <88.24%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff5787...fa51865. Read the comment docs.

@goenning goenning merged commit 179960f into master Nov 26, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the add-api-voters branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment