New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use console logger for migration #657

Merged
merged 6 commits into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@goenning
Copy link
Member

goenning commented Nov 29, 2018

Issue: #653

Enables full log for the migration process

goenning added some commits Nov 29, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 29, 2018

Codecov Report

Merging #657 into master will decrease coverage by 0.37%.
The diff coverage is 76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   73.95%   73.58%   -0.37%     
==========================================
  Files         105      105              
  Lines        6753     6767      +14     
==========================================
- Hits         4994     4979      -15     
- Misses       1396     1425      +29     
  Partials      363      363
Impacted Files Coverage Δ
app/pkg/log/log.go 96.3% <ø> (ø) ⬆️
app/cmd/migrate.go 0% <0%> (ø) ⬆️
app/pkg/log/database/logger.go 70.51% <100%> (+2.46%) ⬆️
app/pkg/dbx/dbx.go 83.07% <100%> (+0.18%) ⬆️
app/pkg/log/noop/logger.go 66.67% <100%> (-1.75%) ⬇️
app/pkg/log/console/logger.go 47.62% <60%> (-28.24%) ⬇️
app/pkg/log/colors.go 25% <0%> (-31.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c681b...ecc3efe. Read the comment docs.

@goenning goenning merged commit e98fdff into master Nov 29, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: push Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-server Your tests passed on CircleCI!
Details
ci/circleci: test-ui Your tests passed on CircleCI!
Details

@goenning goenning deleted the use-console-logger branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment