From 4ae2b29da2c23239b9e9a7a50cd62d79ff03f2e6 Mon Sep 17 00:00:00 2001 From: Giuseppe Criscione Date: Sat, 16 Mar 2019 15:07:26 +0100 Subject: [PATCH] Add type check to `Pages::changePageParent()` --- admin/src/Controllers/Pages.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/admin/src/Controllers/Pages.php b/admin/src/Controllers/Pages.php index a9088063..2ce3cfe3 100755 --- a/admin/src/Controllers/Pages.php +++ b/admin/src/Controllers/Pages.php @@ -489,6 +489,9 @@ protected function changePageId(Page $page, $id) */ protected function changePageParent(Page $page, $parent) { + if (!($parent instanceof Page || $parent instanceof Site)) { + throw new InvalidArgumentException(__METHOD__ . ' accepts only instances of ' . Page::class . ' or ' . Site::class . ' as $parent argument'); + } $destination = $parent->path() . basename($page->path()) . DS; FileSystem::moveDirectory($page->path(), $destination); return new Page($destination);