Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

Inner Exceptions of AggregationException are not logged #81

Closed
ludekcakl opened this issue Jun 16, 2016 · 2 comments
Closed

Inner Exceptions of AggregationException are not logged #81

ludekcakl opened this issue Jun 16, 2016 · 2 comments

Comments

@ludekcakl
Copy link

ludekcakl commented Jun 16, 2016

Expected behavior

If test fails with AggregationException than all inner exception stack traces should be part of ExecutionResult.StackTrace

Actual behavior

Only Message and StackTrace from AggregationException is in the result.

Steps to reproduce

  1. Create test which throws AggregationException containing one or more inner Exceptions
  2. Run the test

Gauge version

0.5.3

Proposed solution

SandBox.cs:70

executionResult.StackTrace =  innerException is AggregationException 
? innerException.ToString() 
: innerException.StackTrace

I can make pull request if you are happy with such change

@sriv
Copy link
Member

sriv commented Jun 21, 2016

Yeah, sounds like a good idea, pull request would be great!

Please note that there is a CLA in place, that you might want to check and sign

@sriv
Copy link
Member

sriv commented Apr 19, 2017

Fix should be available in nightly >= 19/04/17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants