Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook messages not sent to gauge #119

Closed
nehashri opened this issue Dec 6, 2017 · 1 comment
Closed

Hook messages not sent to gauge #119

nehashri opened this issue Dec 6, 2017 · 1 comment

Comments

@nehashri
Copy link
Contributor

nehashri commented Dec 6, 2017

Expected Behaviour

Messages in hooks (Gauge.writeMessage) during execution should be sent to Gauge via the ProtoExecutionResult.

Actual Behaviour

Any message written using Gauge.writeMessage in BeforeScenario, AfterScenario, BeforeSpec, AfterSpec, BeforeSuite and AfterSuite hooks are not sent back to gauge.

Also, messages in BeforeStep and Step are sent to gauge after AfterStep hook is executed.
It should be sent to gauge as soon as that hook is executed.
@nehashri nehashri mentioned this issue Dec 6, 2017
Closed
nehashri pushed a commit that referenced this issue Dec 7, 2017
Sending message with execution hook result. #119
ef66503
Apoorva-GA added a commit that referenced this issue Dec 7, 2017
@Apoorva-GA
Merge pull request #120 from getgauge/hook_messages
c179db9 
Sending message with execution hook result. #119
@nehashri
Copy link
Contributor Author

nehashri commented Dec 7, 2017

Fix should be available in nightly >= 7-12-2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nehashri @sswaroopgupta