Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search tags, specs #157

Merged
merged 1 commit into from Aug 7, 2017
Merged

fix search tags, specs #157

merged 1 commit into from Aug 7, 2017

Conversation

sdvdxl
Copy link
Contributor

@sdvdxl sdvdxl commented Jul 31, 2017

can not search tags and spces and I fixed this problem.

@zabil
Copy link
Member

zabil commented Aug 2, 2017

Thanks for the fix! @sdvdxl
However, these files are generated from a theme repository.

Can you make the changes need in this file instead? https://github.com/getgauge/gauge-mango-theme/blob/8267df15a3e7fc40b1531a6639cef8052b3d5e9b/assets/js/main.js

Once that is done we build and update it here.

@sdvdxl
Copy link
Contributor Author

sdvdxl commented Aug 3, 2017

@zabil I don't know which branch to use,golangTemplate?and I do not find partials.tmpl in the theme which is used in this project. So you can fix the problem self , may be save time.

@sdvdxl
Copy link
Contributor Author

sdvdxl commented Aug 3, 2017

OK. WIth my friend's help,fixed the problem in the theme. And this project should use golangTemplates branch.

@zabil
Copy link
Member

zabil commented Aug 3, 2017

Thanks! will take a look.
Meanwhile. before we merge the code can you sign our CLA?
https://getgauge.io/cla.html

It's a one time requirement.

@sdvdxl
Copy link
Contributor Author

sdvdxl commented Aug 3, 2017

@zabil done

@sriv
Copy link
Member

sriv commented Aug 7, 2017

@sdvdxl - thanks for the PR. I am going to favour this one over your PR to the gauge-mango-theme repository.

We have some changes coming up on gauge-mango-theme, and that may change the way you search. I hope it is ok with you if I merge this change instead. Please let me know.

@sdvdxl
Copy link
Contributor Author

sdvdxl commented Aug 7, 2017

@sriv OK

@sriv sriv merged commit 8b1138f into getgauge:master Aug 7, 2017
@sriv
Copy link
Member

sriv commented Aug 7, 2017

@sdvdxl - thanks for the contribution! Appreciate your patience too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants