Autoload plugin : #562

- Throw error when more than one plugin tries to override the same taiko API
getgauge · May 30, 2019 · 2c8618a · 2c8618a
1 parent 374ef52
commit 2c8618a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/taiko.js b/lib/taiko.js
@@ -2239,13 +2239,19 @@ const loadPlugin = (id, clientHandler) => {
 module.exports.loadPlugin = loadPlugin;
 
 
+const overriddenAPIs = {};
 getPlugins().forEach( (pluginName) => {
     let plugin = require(path.resolve(`node_modules/${pluginName}`));
     loadPlugin(plugin.ID, plugin.clientHandler);
     module.exports[plugin.ID] = plugin;
     for( var api in plugin) {
-        if(module.exports.hasOwnProperty(api))
+        const isApiOverridden = overriddenAPIs.hasOwnProperty(api);
+        if(!isApiOverridden && module.exports.hasOwnProperty(api)) {
             module.exports[api] = plugin[api];
+            overriddenAPIs[api] = pluginName;
+        } else if (isApiOverridden) {
+            throw new Error(`${pluginName} cannot override ${api} API as it has already been overridden by ${overriddenAPIs[api]}`);
+        }
     }
 });