Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in text search / smart selectors #1442

Closed
rmallof opened this issue Aug 22, 2020 · 2 comments · Fixed by #1445
Closed

Regression in text search / smart selectors #1442

rmallof opened this issue Aug 22, 2020 · 2 comments · Fixed by #1445
Assignees
Labels

Comments

@rmallof
Copy link

rmallof commented Aug 22, 2020

Expected behavior

Functions using text search and smart selectors, like click(), should find specified text

Actual behavior

click() using smart selectors does not find the text now, hence, can not click it

Steps to reproduce

  1. https://google-gruyere.appspot.com/start
  2. Click "Agree & start"
  3. Go to Sign up (/newaccount.gtl)
  4. Create a random account
  5. Run taiko:
> openBrowser()
[PASS] Browser opened
> goto("https://google-gruyere.appspot.com/.../login")
  1. Log in with the above account
  2. At this point, you should be at Gruyere Home, where you can see some links at the top. For example, "New Snippet"
  3. In Taiko:
> click("New Snippet")
[FAIL] Error: Element with text New Snippet not found, run `.trace` for more info.

This works well in 1.0.18 but 1.0.19 is breaking some of my tests. May be related to #1429

Versions

node --version
v14.7.0
taiko --version
Version: 1.0.19 (Chromium: 86.0.4214.0) RELEASE

@falcon030
Copy link

falcon030 commented Aug 22, 2020

I think this is caused by the Non-breaking Space between the words "New" and "Snippet".

image

@NivedhaSenthil NivedhaSenthil self-assigned this Aug 24, 2020
NivedhaSenthil added a commit that referenced this issue Aug 24, 2020
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue Aug 24, 2020
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue Aug 25, 2020
* #1442 fix nbsp text search

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* #1442 fix childnode contains

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

Co-authored-by: Zabil Cheriya Maliackal <zabil@users.noreply.github.com>
@rmallof
Copy link
Author

rmallof commented Aug 25, 2020

It's working now, thank you! Awesome resolution time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants