Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercepting with unicode characters #257

Closed
sswaroopgupta opened this issue Nov 12, 2018 · 2 comments
Closed

Intercepting with unicode characters #257

sswaroopgupta opened this issue Nov 12, 2018 · 2 comments
Assignees

Comments

@sswaroopgupta
Copy link
Contributor

Expected behavior
I should be able to intercept by specifying unicode characters in the URL

Current behavior
Currently I cannot intercept by specifying unicode characters in the URL

await intercept("https://ko.wikipedia.org/wiki/위키백과:대문",{body:{"city":"City D2+","state":"State D2+"}});
await goto("https://ko.wikipedia.org/wiki/위키백과:대문");

however

await intercept("https://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8",{body:{"city":"City D2+","state":"State D2+"}});         
await goto("https://ko.wikipedia.org/wiki/위키백과:대문");

works.

Steps to replicate

  • Run the taiko script in observe mode
const { openBrowser, intercept, goto } = require('taiko');

(async () => {
    try {
        await openBrowser();
        await intercept("https://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8",{body:{"city":"City D2+","state":"State D2+"}});
        await goto("https://ko.wikipedia.org/wiki/위키백과:대문");
    } catch (e) {
        console.error(e);
    } finally {
        await closeBrowser();
    }
})();

We get the mocked response

  • Run the taiko script in observe mode
const { openBrowser, intercept, goto } = require('taiko');

(async () => {
    try {
        await openBrowser();
        await intercept("https://ko.wikipedia.org/wiki/위키백과:대문",{body:{"city":"City D2+","state":"State D2+"}});
        await goto("https://ko.wikipedia.org/wiki/위키백과:대문");
    } catch (e) {
        console.error(e);
    } finally {
        await closeBrowser();
    }
})();

We do not get the mocked response.

Version

commit - 3d16901cf6cdc76bdc726ccf43bff875c23472e2
@nehashri nehashri removed the triage label Apr 23, 2019
@Apoorva-GA Apoorva-GA self-assigned this Apr 29, 2019
NivedhaSenthil added a commit that referenced this issue May 2, 2019
@Apoorva-GA
Copy link
Contributor

Fix should be available in 6d41672

@Debashis9012
Copy link
Contributor

This has been verified and found fixed with the version 6d41672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants