Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to click on Submit button with click("Submit") #312

Closed
sguptatw opened this issue Dec 27, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@sguptatw
Copy link
Contributor

commented Dec 27, 2018

Expected behavior
Should be able to click on Submit button with click("Submit")

Actual behavior
When an input element with type submit is used the UI is rendered with a button with text "Submit". click("Submit") says Error: Element with text Submit not found, run .trace for more info.

Steps to replicate

  • Create a html file
<html>
<body>
​
<form action="/action_page.php">
  <input type="submit">
</form>
​​
</body>
</html>
  • Open the REPL
> openBrowser()
 ✔ Browser opened
> goto("file:///Users/sswaroop/Desktop/newFile.html")
 ✔ Navigated to url "file:///Users/sswaroop/Desktop/newFile.html"
> click("Submit")
 ✘ Error: Element with text Submit not found, run `.trace` for more info.

Here what is visible to the user is the text "Submit" however in the DOM the input is type="submit"

@NivedhaSenthil

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Fix available in fb02d59

@NivedhaSenthil NivedhaSenthil added ready for QA and removed triage labels Jan 7, 2019

@sguptatw

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

Issue replicable with the same steps as original issue with commit - 0de7dca

@sguptatw sguptatw added ready and removed ready for QA labels Jan 8, 2019

NivedhaSenthil added a commit that referenced this issue Jan 8, 2019

@NivedhaSenthil

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

Text made case insensitive now. Fix available in 99fca06

@NivedhaSenthil NivedhaSenthil added ready for QA and removed ready labels Jan 8, 2019

@sguptatw

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

Verified on version 5ca341b78e2c14c2347206209d15df79955699bc

@sguptatw sguptatw closed this Jan 8, 2019

@sguptatw sguptatw removed the ready for QA label Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.