Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenoid support #1709

Merged
merged 19 commits into from Dec 8, 2020
Merged

Selenoid support #1709

merged 19 commits into from Dec 8, 2020

Conversation

NivedhaSenthil
Copy link
Member

@NivedhaSenthil NivedhaSenthil commented Dec 1, 2020

  • Refactor cri.List usage
  • provide an option for plugins to register hooks that Taiko allows
  • add docs for hooks

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@saikrishna321
Copy link
Member

@NivedhaSenthil openTab works fine. closeTab switches the tab and does not close the current tab

saikrishna321 and others added 3 commits December 4, 2020 14:06
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@gaugebot
Copy link

gaugebot bot commented Dec 5, 2020

@NivedhaSenthil Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@NivedhaSenthil NivedhaSenthil merged commit 854119b into master Dec 8, 2020
@NivedhaSenthil NivedhaSenthil deleted the selenoid_support branch December 8, 2020 03:47
saikrishna321 added a commit to saikrishna321/taiko that referenced this pull request Jan 15, 2021
* getgauge#1684 refactor list usage

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Clean up console log

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* add hooks support for plugins

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Fix destructing assignment

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Add tests for registering hooks

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Fix default hook

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Add docs for hooks

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* remove use of cri List

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Provide option to set alterPath

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* fix target handler for selenoid

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* fix tests

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* fix targethandler tests

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* remove use of cri.Close

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* fix tests

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* Bump version to 1.1.0

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

Co-authored-by: Sai Krishna <saikrishna321@yahoo.com>
Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants