Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider screenorientation for emulateDevice else default to potrait #392

Merged
merged 4 commits into from Feb 11, 2019

Conversation

@saikrishna321
Copy link
Contributor

saikrishna321 commented Feb 8, 2019

No description provided.

@sriv sriv added the ready label Feb 8, 2019
@gaugebot gaugebot bot added the cla-signed label Feb 8, 2019
@@ -60,6 +62,7 @@ step('Assert url host is <hostName>', async function(hostName) {
});

step('Assert page navigated back', async function() {
waitFor(intervalSecs(5));

This comment has been minimized.

Copy link
@NivedhaSenthil

NivedhaSenthil Feb 11, 2019

Member

I feel we should spend time looking at what is actually causing the timeout rather than adding waits since adding waits will make tests flaky anyways. We want to avoid using waits in our test suites to capture any scenario where we have to wait for right responses.

I agree there will be scenarios where application might demand waits, but IMO for this scenario we can spend some time understanding whats happening behind page navigations to handle it as in Taiko. Thoughts ?

lib/emulationHandler.js Show resolved Hide resolved
@NivedhaSenthil NivedhaSenthil merged commit 82aa312 into getgauge:master Feb 11, 2019
1 of 2 checks passed
1 of 2 checks passed
Taiko-CI in progress
Details
verification/cla-signed
@NivedhaSenthil NivedhaSenthil removed the ready label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.