Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] [Paid] Spell Check in Page Editor #1266

Closed
artofthesmart opened this issue Nov 11, 2017 · 11 comments
Closed

[FR] [Paid] Spell Check in Page Editor #1266

artofthesmart opened this issue Nov 11, 2017 · 11 comments
Assignees
Labels

Comments

@artofthesmart
Copy link

@artofthesmart artofthesmart commented Nov 11, 2017

Right now the admin plugin uses a WYSIWYG editor for pages, but it doesn't allow the browser's native spell-checker to work properly. Leaves you in a bit of a lurch.

Would be nice to alter the editor to allow that to work properly.

@rhukster
Copy link
Member

@rhukster rhukster commented Nov 16, 2017

It's a limitation of the editor we use (CodeMirror), as it's not using a standard HTML field that supports spell check, and a JS solution would require a HUGE dictionary database in potentially every language.

@rhukster
Copy link
Member

@rhukster rhukster commented Nov 16, 2017

BTW, this could be solved with an alternate editor.

@dcrobertson01
Copy link

@dcrobertson01 dcrobertson01 commented Feb 20, 2018

Can we disable the wysiwyg editor? I'd take a spell check over wysiwyg any day.

@artofthesmart
Copy link
Author

@artofthesmart artofthesmart commented Feb 20, 2018

I've had some success with just editing stuff directly in -gulp- SSH. Vim has spellcheck that does well enough and I've been meaning to learn how to use it. ;)

@amoliski
Copy link

@amoliski amoliski commented Aug 1, 2018

Would this plugin be reasonable to use?

https://github.com/sparksuite/codemirror-spell-checker

@de1mat
Copy link

@de1mat de1mat commented Feb 10, 2019

Has anyone managed to integrate this plugin with Grav? If so, any tips on how to do this?

@RomainLWiz
Copy link

@RomainLWiz RomainLWiz commented Sep 2, 2019

Do you have any news or have you started the project since the last return ?

@artofthesmart
Copy link
Author

@artofthesmart artofthesmart commented Sep 2, 2019

I feel like it would probably be done as a build of CM with the spell checker included, and that comes with all the same baggage as other Grav includes (e.g. security reviews). There's also the matter of size: the owner of CM didn't want to bundle the spellcheck by default because it's so large (sauce). Typo.js (and the CM Spell Checker link above) add ~750kb and that's just for en-us. Not commenting if that's a sufficient reason not to do it, just relaying info into this thread. :)

EDIT: Now that I look, the size issue was raised in 2013, so...maybe things've changed since then?

@RomainLWiz
Copy link

@RomainLWiz RomainLWiz commented Nov 27, 2019

Would this plugin be reasonable to use?

https://github.com/sparksuite/codemirror-spell-checker

What one has managed to implement ?

@Rolf-Smit
Copy link

@Rolf-Smit Rolf-Smit commented Feb 2, 2021

So what I did to "solve" the problem, was to add: 'spellcheck': 'true', 'inputStyle': 'contenteditable', to user/plugins/admin/themes/grav/templates/forms/fields/codemirror/codemirror.html.twig and to user/plugins/admin/themes/grav/templates/forms/fields/editor/editor.html.twig and on at least Firefox this works perfectly (at least for my needs). I'm not a website guru, so don't take my word for it. But it seems to be working fine, something to consider to implement in the next version of Admin?

@mahagr
Copy link
Member

@mahagr mahagr commented Feb 8, 2021

CC @w00fz @rhukster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants