Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Plugins Based on GetHerbert Doesn't Work #23

Closed
kkeiper1103 opened this issue Apr 18, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@kkeiper1103
Copy link

commented Apr 18, 2015

I was trying to get two plugins based on get herbert to work. I develop some plugins and am looking for something a little more standardized, so I started using this. I got through developing a beta of one plugin and went to start another one.

I had to deactivate the first getherbert based plugin before the second one would activate. I'm assuming it's because each getherbert based plugin tries to define("HERBERT_CONFIG", true);

@jasonagnew

This comment has been minimized.

Copy link
Member

commented Apr 18, 2015

Yip there’s a namespace issue. Something I didn’t think about when I first built Herbert. It was spotted pretty quick so decided to rewrite it to avoid the issue:

https://github.com/getherbert/herbert/tree/rewrite

https://github.com/getherbert/framework

I plan this month to get the docs updated and get back to keeping on top of issues.

@gurkanoluc

This comment has been minimized.

Copy link

commented Apr 25, 2015

@jasonagnew hi there, I have quick question. The code in the rewrite branch is ready for production use but just doesn't have docs? Or is it still in development?

@jasonagnew

This comment has been minimized.

Copy link
Member

commented Jun 2, 2015

Sorry for the long delay @kkeiper1103 @gurkanoluc - the rewrite is now complete and now on the dev branch. The core is on v0.9.5, I plan to make a few small changes over the next week as we get close to launching v1.

@jasonagnew jasonagnew closed this Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.