{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":542505030,"defaultBranch":"main","name":"hop-cli","ownerLogin":"gethop-dev","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-09-28T09:17:46.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/104641025?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714467356.0","currentOid":""},"activityList":{"items":[{"before":"f4b8b880ce0b7a69b9e3b5de6b48548d9e58b99b","after":"bd5dfe8da05196481a6079b67490a34599aad756","ref":"refs/heads/main","pushedAt":"2024-04-30T08:56:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Prepare for next development release","shortMessageHtmlLink":"Prepare for next development release"}},{"before":"605f0e375ce2230bd301a0f76175d570ffaf7ce8","after":"f4b8b880ce0b7a69b9e3b5de6b48548d9e58b99b","ref":"refs/heads/main","pushedAt":"2024-04-28T19:35:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Random password generation sometimes uses incompatible characters\n\nSome background for the changes introduced in this commit.\n\nThe unexpected behavior detected by @werenall in #24 seems to be\nrelated with a change in the semantics of the processing of\n\"environment files\" in docker-compose (and `docker compose`). In older\nversions, variable definitions didn't have any kind of expansion /\ninterpolation. E.g.:\n\n   VAR=$OTHERVAR\n\nwould make VAR have exactly the string `$OTHERVAR` (verbatim) as its\nvalue. At some point, this behavior was changed (but not documented!)\nin docker-compose. But it was changed in an inconsistent\nway (different versions having slightly different behaviors). And in\nSept 2022, the documentation was updated to reflect the changes, and\nmake them the official behavior.\n\nIt seems that our code for the creation of \"environment files\"\npre-dates those changes in the documentation. In addition to that, we\nseem to be using older versions of docker-compose (i.e., not the\n\"latest and greatest\"), so we didn't catch some edge cases.\n\nGiven that:\n\n- the minimum required docker-compose version for HOP is 1.27.0,\n\n- version 1.27.0 is the first version that fully implements the\n  \"compose specification\"[1],\n\n- and that the \"compose specification\" is where the change in the\n  expansion / interpolation is standardized,\n\nwe have decided to quote the values of the variables in the\n\"environment file\" we produce. For that, we need to make sure we quote\nany single quotes that are part of the original value, which in turn\nmeans we need to quote any quotes that were part of the original value.\n\n[Re: #24]\n\n[1] https://compose-spec.io/","shortMessageHtmlLink":"Random password generation sometimes uses incompatible characters"}},{"before":"147276739a4b3bddd573dfb8c75a1157e14b1a21","after":"605f0e375ce2230bd301a0f76175d570ffaf7ce8","ref":"refs/heads/main","pushedAt":"2024-04-12T16:13:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Prepare for next development release","shortMessageHtmlLink":"Prepare for next development release"}},{"before":"bd00a1f7b97c8965332799fff36421e5c5e7a05e","after":"147276739a4b3bddd573dfb8c75a1157e14b1a21","ref":"refs/heads/main","pushedAt":"2024-04-12T16:10:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Release 0.1.11","shortMessageHtmlLink":"Release 0.1.11"}},{"before":"129f801d92d43be15f9cbb8ab32391250037fa66","after":"bd00a1f7b97c8965332799fff36421e5c5e7a05e","ref":"refs/heads/main","pushedAt":"2024-04-12T16:05:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Use at least ten chars for the SHA1 prefix for commits\n\nThe git SHA1 prefix that we obtain when running git log --oneline\nlocally in our repos, and the SHA1 prefixes that are calculated by\nci/common-vars.sh (to build what we internally call the \"version tag\")\nin all the projects that are HOP based, sometimes don't \"match\". In\nthe sense that, the same SHA1 prefix computed by each of them, for the\nsame commit, has a different length. The output of one of those\ncommands is sometimes longer than the other (e.g., one outputs a 7\ncharacters SHA1 prefix, and the other a 8 characters SHA1 prefix).\n\nThis can introduce confusion for us, and let us use the wrong SHA1\nprefix in the Docker images names that we use to deploy things, if\ndone manually (this is less of an issue in projects configured to be\ndeployed to AWS Elastic Beanstalk, as the deployment bundles are\ncreated in the CI/CD pipeline as well, using the same SHA1 prefix in\ncall cases).\n\nThis is not a theoretical issue, as some of use have suffered it one\nor more times 😁\n\nSo we have decided that we are going to use at least 10 chars for the\nSHA1 prefixes. This assures us that we will have a fixed (and\npredictable) amount of characters in the \"version tags\", no matter\nwhere we run that command. The documentation got git rev-parse says\nthat the number we specify there is the minimum amount of chars in the\nSHA1 prefix. There may be more, if there are more than one commit in\nthe repo with the same prefix. Using 10 characters makes that\nunlikely.\n\nBut if we hit that unlikely case, we would always get the same amount\nof characters for that commit (until some point in the future when a\nthird potential commit would collide with that amount of chars; but\nthat wouldn't be a big problem, as we would have already deployed the\nversion with the \"colliding tag\" in the past, etc.)\n\n[Fixes: #23]","shortMessageHtmlLink":"Use at least ten chars for the SHA1 prefix for commits"}},{"before":"d697f7c626c7b152bdf3c074d318c98dc617962b","after":"129f801d92d43be15f9cbb8ab32391250037fa66","ref":"refs/heads/main","pushedAt":"2024-04-12T15:35:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Update hop-cli version on AWS platform prebuild script\n\nWe were using a very old version of hop-cli in the\n02-install-hop-cli.sh script. Update it to the latest stable version.\n\n[Re: #15]","shortMessageHtmlLink":"Update hop-cli version on AWS platform prebuild script"}},{"before":"ad0da87fa08471819784afebdc33abf0416fe3b3","after":"d697f7c626c7b152bdf3c074d318c98dc617962b","ref":"refs/heads/main","pushedAt":"2024-04-12T15:29:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Make sure we use the same babashka and clj-kondo versions everywhere\n\nOnce we are changing versions in some places, upgrade the to the\nlatest stable versions everywhere.\n\n[Fixes #16]","shortMessageHtmlLink":"Make sure we use the same babashka and clj-kondo versions everywhere"}},{"before":"afac87121f1337ffba133458a3ff6dc9ea8c0367","after":"ad0da87fa08471819784afebdc33abf0416fe3b3","ref":"refs/heads/main","pushedAt":"2024-04-12T15:16:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Upgrade duct/compiler.sass to 0.3.0\n\nThis should fix the issue described in #20, when using Apple Silicon\nhardware to develop HOP-based projects.\n\n[Fixes #20]\n[Fixes #22]","shortMessageHtmlLink":"Upgrade duct/compiler.sass to 0.3.0"}},{"before":"eb0ef310e7da97c7a86f688076bf9b61ee1c9764","after":"afac87121f1337ffba133458a3ff6dc9ea8c0367","ref":"refs/heads/main","pushedAt":"2024-03-21T11:22:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Upgrade jwt-oidc library to latest version\n\nIt fixes an important bug related to checking the 'aud' claim (that\ncould lead to a security vulnerability).","shortMessageHtmlLink":"Upgrade jwt-oidc library to latest version"}},{"before":"e729c76ca526764c5a88327303dedcc66857ae94","after":"eb0ef310e7da97c7a86f688076bf9b61ee1c9764","ref":"refs/heads/main","pushedAt":"2024-03-12T14:24:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"Fix hop-cli http client hiding certain failed http request errors\n\n[Re #21]","shortMessageHtmlLink":"Fix hop-cli http client hiding certain failed http request errors"}},{"before":"d4e3b2a4e1e61af4f612f34f0dd8fa6d36719945","after":"e729c76ca526764c5a88327303dedcc66857ae94","ref":"refs/heads/main","pushedAt":"2024-03-10T15:34:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Update Changelog with previous fix","shortMessageHtmlLink":"Update Changelog with previous fix"}},{"before":"4a9f674d1e765e53592549c5deb72907ea658ff7","after":"d4e3b2a4e1e61af4f612f34f0dd8fa6d36719945","ref":"refs/heads/main","pushedAt":"2024-03-10T15:32:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Fix incomplete S3 policy\n\nThe S3 policy we were creating was granting permissions at the bucket\nlevel only. Not on the objects created inside the bucket.\n\nSo in practice the get/put/delete object statements were not being\napplied. We needed to add a second resource like:\n\"arn:aws:s3:::<project-name>-<environment>-env/*\"\n\n[Fixes: #19]","shortMessageHtmlLink":"Fix incomplete S3 policy"}},{"before":"9ddaf077b79e5ec46cafa56cf1f15b36c3a3f267","after":"4a9f674d1e765e53592549c5deb72907ea658ff7","ref":"refs/heads/main","pushedAt":"2024-01-13T23:58:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Keycloak JS adapter must be instanciated with the new operator\n\nFrom https://www.keycloak.org/docs/latest/upgrading/index.html#migrating-to-21-1-0\n\n    Historically it has been possible to create an instance of the\n    Keycloak JS adapter by calling the Keycloak() function directly.\n\n    To align this with modern conventions in the JavaScript world it\n    has been possible to use the new operator to create an instance\n    instead.\n\n    The function-style constructor has been deprecated for a while,\n    but starting this version we will actively log a deprecation\n    message when it used. This style of constructor will be removed in\n    a future version so make sure to migrate your code to use the new\n    operator.","shortMessageHtmlLink":"Keycloak JS adapter must be instanciated with the new operator"}},{"before":"538e67cc63d6315cbcb68a1757d6b3494a0898bf","after":"9ddaf077b79e5ec46cafa56cf1f15b36c3a3f267","ref":"refs/heads/main","pushedAt":"2023-12-31T15:24:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Enable the use of PKCE for OIDC auth\n\nOAuth 2.0 public clients (and by extension, OpenID Connect clients, as\nit's based on it) utilizing the Authorization Code Grant are\nsusceptible to the authorization code interception attack. The PKCE\nspecification[1] describes the attack as well as a technique to\nmitigate against the threat through the use of Proof Key for Code\nExchange (PKCE, pronounced \"pixy\").\n\nAs the SPA we use for the front-end is a public client that is using\nthe Authorization Code Grant, we want to enable the use of PKCE for\nthis authentication flow against the IdP (Keycloak in our case).\n\n[1] https://www.rfc-editor.org/rfc/rfc7636","shortMessageHtmlLink":"Enable the use of PKCE for OIDC auth"}},{"before":"27f8f04a9434775ff9146c8e6e0caa0f044f916d","after":"538e67cc63d6315cbcb68a1757d6b3494a0898bf","ref":"refs/heads/main","pushedAt":"2023-11-13T15:39:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"Fix CHANGELOG","shortMessageHtmlLink":"Fix CHANGELOG"}},{"before":"3af0ea4b879a9de43cf31fd2a3ef2df200fed742","after":"27f8f04a9434775ff9146c8e6e0caa0f044f916d","ref":"refs/heads/main","pushedAt":"2023-11-13T15:03:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"Release 0.1.10","shortMessageHtmlLink":"Release 0.1.10"}},{"before":"73a8edce5ddcbc2ce7088040ecf17a99aab6f907","after":"3af0ea4b879a9de43cf31fd2a3ef2df200fed742","ref":"refs/heads/main","pushedAt":"2023-10-24T10:41:16.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"[ci] Fix github-actions always including AWS env variables","shortMessageHtmlLink":"[ci] Fix github-actions always including AWS env variables"}},{"before":"776d497ff214a47c19b85698bc26312b8c8a3bb9","after":"73a8edce5ddcbc2ce7088040ecf17a99aab6f907","ref":"refs/heads/main","pushedAt":"2023-10-24T06:43:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"[cloudformation] Remove S3 bucket 'AccessControl' definition\n\nAWS recommends no longer using that property. By default all buckets\nare private.","shortMessageHtmlLink":"[cloudformation] Remove S3 bucket 'AccessControl' definition"}},{"before":"d50c057ab98c36fd3c37beed85e0a8b01ebf310a","after":"776d497ff214a47c19b85698bc26312b8c8a3bb9","ref":"refs/heads/main","pushedAt":"2023-10-24T06:30:38.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"[authentication profile] Replace ratom with atom for keycloak obj\n\nUsing a ratom is not really necessary.","shortMessageHtmlLink":"[authentication profile] Replace ratom with atom for keycloak obj"}},{"before":"ba35b35a24ca303b97bee196209cfd5085795ece","after":"d50c057ab98c36fd3c37beed85e0a8b01ebf310a","ref":"refs/heads/main","pushedAt":"2023-10-17T08:47:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"Update changelog take 2","shortMessageHtmlLink":"Update changelog take 2"}},{"before":"65d50f750af0ee9bb2fdff5603adbe3da84ac6dc","after":"ba35b35a24ca303b97bee196209cfd5085795ece","ref":"refs/heads/main","pushedAt":"2023-10-17T08:45:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"Update changelog","shortMessageHtmlLink":"Update changelog"}},{"before":"4b4f4bdfd18c9c8c64bc38302a251be7acf31c14","after":"65d50f750af0ee9bb2fdff5603adbe3da84ac6dc","ref":"refs/heads/main","pushedAt":"2023-10-17T08:37:32.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"bgalartza","name":"Bingen Galartza Iparragirre","path":"/bgalartza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933620?s=80&v=4"},"commit":{"message":"Fix settings and cli version check\n\nWe can't directly treat them as strings because it leads to unexpected\nresults when the strings don't have the same length/structure.","shortMessageHtmlLink":"Fix settings and cli version check"}},{"before":"f1cb3c60c40b6db7939a1ffbe7482dbd248c5a6f","after":"4b4f4bdfd18c9c8c64bc38302a251be7acf31c14","ref":"refs/heads/main","pushedAt":"2023-05-30T19:04:29.736Z","pushType":"push","commitsCount":5,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Prepare for next development release","shortMessageHtmlLink":"Prepare for next development release"}},{"before":"e375aa242ee89dc567201ad13beef73340fb68fb","after":"f1cb3c60c40b6db7939a1ffbe7482dbd248c5a6f","ref":"refs/heads/main","pushedAt":"2023-05-28T10:01:27.608Z","pushType":"push","commitsCount":2,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Prepare for next development release","shortMessageHtmlLink":"Prepare for next development release"}},{"before":"f5f24302b481668a8504c3a60b2f1029425acd1a","after":"e375aa242ee89dc567201ad13beef73340fb68fb","ref":"refs/heads/main","pushedAt":"2023-05-28T09:54:51.025Z","pushType":"push","commitsCount":3,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"\"reset\" volume paths that are supposed to be relative\n\nWe shouldn't turn them into absolute paths (much less with an\narbitrary path). We need to keep them as relative paths, like they\ninitially were. That allows us to place the on-premises deployment\nfiles in arbitrary places. And docker-compose will still be able to\nuse the files/directories that are located in the bundle itself (as\nopposed to those that are elsewhere, like the persistent data\ndirectories).","shortMessageHtmlLink":"\"reset\" volume paths that are supposed to be relative"}},{"before":"723fb00ccccdde8be37028edd59b9bb117c4953c","after":"f5f24302b481668a8504c3a60b2f1029425acd1a","ref":"refs/heads/main","pushedAt":"2023-05-07T09:32:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Prepare for next development release","shortMessageHtmlLink":"Prepare for next development release"}},{"before":"153a9d2d4a51c81727743ade415bbd684f44a142","after":"723fb00ccccdde8be37028edd59b9bb117c4953c","ref":"refs/heads/main","pushedAt":"2023-05-07T09:24:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iarenaza","name":"Iñaki Arenaza","path":"/iarenaza","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241751?s=80&v=4"},"commit":{"message":"Fix permissions in the deployment bundle files\n\nCertain CI environments set an overly permissive umask. That means the\ngit checkout and any files we create in the CI scripts have too many\npermissions. And when we copy the existing checkout files into the\nbundle, we also copy the permissive access. We need to copy the files\nwith their original permissions, because some of then need to be\nexecutables, etc. But we don't want the \"extra\" permissions added\nbecause of the CI environments umask.\n\nSo we take a two pronged approach:\n\n- We set a reasonable umask at the beginning of the bundle creation\n  script.\n- When creating the final bundle tar file, we remove the most dangerous\n  ones ('group' and 'other' write permissions).","shortMessageHtmlLink":"Fix permissions in the deployment bundle files"}},{"before":"1944f03c086c64b39d8c99b4433cff27e79115cc","after":"153a9d2d4a51c81727743ade415bbd684f44a142","ref":"refs/heads/main","pushedAt":"2023-03-21T09:23:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lucassousaf","name":"Lucas Sousa","path":"/lucassousaf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933642?s=80&v=4"},"commit":{"message":"Prepare for next development release","shortMessageHtmlLink":"Prepare for next development release"}},{"before":"a4a2c25e61adde1b245cd1cad41f040e8cb2aebf","after":"1944f03c086c64b39d8c99b4433cff27e79115cc","ref":"refs/heads/main","pushedAt":"2023-03-21T09:18:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lucassousaf","name":"Lucas Sousa","path":"/lucassousaf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46933642?s=80&v=4"},"commit":{"message":"Release 0.1.6","shortMessageHtmlLink":"Release 0.1.6"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEPcr0kgA","startCursor":null,"endCursor":null}},"title":"Activity · gethop-dev/hop-cli"}