Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23 basic checker tests #36

Merged
merged 4 commits into from Mar 2, 2019

Conversation

Projects
None yet
2 participants
@mraak
Copy link
Collaborator

mraak commented Mar 1, 2019

You will notice that test #6 now fails, but that's expected due to #28 being now in place. I just let it fail for you to see the original requirement and how it fails with the upgraded functionality.

Failed: 'Checker: #6 number sub-types' (1/2)

@getify

This comment has been minimized.

Copy link
Owner

getify commented on tests/tests.checker.js in 3f2e7ff Feb 26, 2019

The mistake (causing the problem with the test when only using inline code) is in this line.

It currently says:

let code = `var a = any;

It should be:

let code = `var a = any\`\`;

@mraak mraak requested a review from getify Mar 1, 2019

@getify

getify approved these changes Mar 1, 2019

Copy link
Owner

getify left a comment

These look fine to me for now. I think eventually we want the tests not just to assert on the count of errors, but on which specific errors (by ID) are expected. We'd need to expose the MSG.* constants for use by the test assertions, so that as the numbers get re-assigned it won't break all the tests.

@mraak mraak merged commit a329032 into master Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.