New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for poem #1185

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@victor-homyakov

victor-homyakov commented Nov 16, 2017

Unfortunately citation breaks poem formatting, so I've wrapped poem in a fenced code block

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).

Fix formatting for poem
Unfortunately citation breaks poem formatting, so I've wrapped poem in a fenced code block
@getify

This comment has been minimized.

Show comment
Hide comment
@getify

getify Nov 16, 2017

Owner

It's a long quote, so I think blockquote (as currently formatted) is the most correct semantic, right? It's not code, so why format it with a code fence? Only to get fixed-width font (in some readers)?

Owner

getify commented Nov 16, 2017

It's a long quote, so I think blockquote (as currently formatted) is the most correct semantic, right? It's not code, so why format it with a code fence? Only to get fixed-width font (in some readers)?

@victor-homyakov

This comment has been minimized.

Show comment
Hide comment
@victor-homyakov

victor-homyakov Nov 20, 2017

The problem is, with blockquote poem is not formatted properly: it's rendered as a single long string. The only way I've found so far to preserve original formatting is to use code fence.

victor-homyakov commented Nov 20, 2017

The problem is, with blockquote poem is not formatted properly: it's rendered as a single long string. The only way I've found so far to preserve original formatting is to use code fence.

@getify

This comment has been minimized.

Show comment
Hide comment
@getify

getify Nov 20, 2017

Owner

Ahhh.. I never spotted that formatting issue in markdown before (as the printed book formatting was corrected).

I think the better "fix" is to have a new blank quote line in between each, like this:

> Let this long package float,
>
> Goto private class if short.
>
> While protected with debugger case,
>
> Continue volatile interface.
>
> Instanceof super synchronized throw,
>
> Extends final export throws.
>
>  
>
> Try import double enum?
>
> - False, boolean, abstract function,
>
> Implements typeof transient break!
>
> Void static, default do,
>
> Switch int native new.
>
> Else, delete null public var
>
> In return for const, true, char
>
> …Finally catch byte.

Which renders in markdown as:

Let this long package float,

Goto private class if short.

While protected with debugger case,

Continue volatile interface.

Instanceof super synchronized throw,

Extends final export throws.

 

Try import double enum?

  • False, boolean, abstract function,

Implements typeof transient break!

Void static, default do,

Switch int native new.

Else, delete null public var

In return for const, true, char

…Finally catch byte.

Owner

getify commented Nov 20, 2017

Ahhh.. I never spotted that formatting issue in markdown before (as the printed book formatting was corrected).

I think the better "fix" is to have a new blank quote line in between each, like this:

> Let this long package float,
>
> Goto private class if short.
>
> While protected with debugger case,
>
> Continue volatile interface.
>
> Instanceof super synchronized throw,
>
> Extends final export throws.
>
>  
>
> Try import double enum?
>
> - False, boolean, abstract function,
>
> Implements typeof transient break!
>
> Void static, default do,
>
> Switch int native new.
>
> Else, delete null public var
>
> In return for const, true, char
>
> …Finally catch byte.

Which renders in markdown as:

Let this long package float,

Goto private class if short.

While protected with debugger case,

Continue volatile interface.

Instanceof super synchronized throw,

Extends final export throws.

 

Try import double enum?

  • False, boolean, abstract function,

Implements typeof transient break!

Void static, default do,

Switch int native new.

Else, delete null public var

In return for const, true, char

…Finally catch byte.

@victor-homyakov

This comment has been minimized.

Show comment
Hide comment
@victor-homyakov

victor-homyakov Nov 21, 2017

Formatting for this fragment still looks a bit weird

Try import double enum?

  • False, boolean, abstract function,

Implements typeof transient break!

Compare it with original

Try import double enum?
- False, boolean, abstract function,
Implements typeof transient break!

victor-homyakov commented Nov 21, 2017

Formatting for this fragment still looks a bit weird

Try import double enum?

  • False, boolean, abstract function,

Implements typeof transient break!

Compare it with original

Try import double enum?
- False, boolean, abstract function,
Implements typeof transient break!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment