Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Steadily increasing memory usage #287

Closed
tthayer opened this issue Jun 6, 2017 · 3 comments
Closed

[Performance] Steadily increasing memory usage #287

tthayer opened this issue Jun 6, 2017 · 3 comments

Comments

@tthayer
Copy link

tthayer commented Jun 6, 2017

Overview

  • Insomnia Version: 5.1.1
  • Operating System: Windows 7
  • Summary: Insomnia gradually uses more and more RAM regardless of if I'm using it actively or not. I have left it open for several days and have seen it using ~4GB. Watching Task Manager, it appears that Insomnia will consume an additional 1MB every minute or two. Restarting the application frees up memory. I've seen this happen with another Electron app (Slack) too, though it appears they got a handle on it and it doesn't exhibit the same behavior anymore.

How To Reproduce

Please list all pertinent information and steps needed to reproduce the issue. For example:

  1. Open Insomnia
  2. Observe memory usage. Wait a while. Observe markedly higher memory usage.

Other Notes

In the time it took me to write this up it consumed +~12MB. Could this be related to logging?

@gschier gschier changed the title Steadily increasing memory usage [Performance] Steadily increasing memory usage Jun 7, 2017
@gschier
Copy link
Contributor

gschier commented Jun 26, 2017

Sorry for the delay on this one. I haven't had a big enough time block to dig into this, but I do want to get to it soon. The DB that insomnia uses is in-memory, so large requests and responses will quickly inflate the amount of RAM needed. My initial solution for this will be to pull large blobs (request and response bodies) out of the DB and store them directly on the file system.

As for leaks, I'm not seeing any on my end when the app is idle. I observe memory increasing for around 30 seconds, but eventually returning back down (probably after garbage collection).

@tthayer
Copy link
Author

tthayer commented Jun 28, 2017

I'll keep an eye on it and see if it continues.

@gschier
Copy link
Contributor

gschier commented Jun 30, 2017

Going to close this one for now as I suspect #338 will clear up most memory-related issues.

@gschier gschier closed this as completed Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants