[Re-Submitted] Added support for file extension filtering as well as ability to select a directory to file picker dialog #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies to the file input picker.
…v to pass in array of what types they want (file/directory)
|
Looks like my IDE performed some auto-formatting. Let me know if you'd like me to revert those formatting changes. |
|
Thanks for the PR @nickhomme! Since it's such a small PR, the formatting stuff is fine. It's easy enough to find the meaningful code changes 😄 👍 |
|
@gschier |
|
It's okay. Sometimes that last one doesn't run for some reason. Also, I haven't forgotten about this. Going to get it into the next release for sure! |
gschier
approved these changes
Nov 6, 2018
|
Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌 |
luizmariz
pushed a commit
to luizmariz/insomnia
that referenced
this pull request
Jan 22, 2020
…ability to select a directory to file picker dialog (Kong#1131) * Added file extensions filtering as well as ability to select directories to the file input picker. * Removed redundant code using just one type 'file' and allowing the dev to pass in array of what types they want (file/directory) * Fixed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for the file input to have a file type filter applied as well as the ability to select directories if allowed.
Reasoning for this is to provide plugins the ability to have more complex capabilities such as looping through files in a directory or only allowing certain files to be selected.
Possible improvements would be to also allow option of multiple files to be selected.